-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add upgrading guide for v8 #1517
Merged
Shinigami92
merged 17 commits into
faker-js:next
from
matthewmayer:chore/upgrading-to-8
Nov 21, 2022
Merged
docs: add upgrading guide for v8 #1517
Shinigami92
merged 17 commits into
faker-js:next
from
matthewmayer:chore/upgrading-to-8
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1517 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2216 2216
Lines 238845 238845
Branches 1029 1029
=======================================
Hits 237983 237983
Misses 841 841
Partials 21 21 |
ST-DDT
reviewed
Nov 4, 2022
ST-DDT
added
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
labels
Nov 4, 2022
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
This was referenced Nov 5, 2022
ST-DDT
previously approved these changes
Nov 5, 2022
ST-DDT
reviewed
Nov 5, 2022
Co-authored-by: ST-DDT <[email protected]>
ST-DDT
requested changes
Nov 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ST-DDT
previously approved these changes
Nov 7, 2022
ST-DDT
reviewed
Nov 20, 2022
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
ST-DDT
approved these changes
Nov 20, 2022
Shinigami92
approved these changes
Nov 20, 2022
import-brain
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1518