Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add upgrading guide for v8 #1517

Merged
merged 17 commits into from
Nov 21, 2022

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Nov 4, 2022

fix #1518

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1517 (b706fce) into next (a338bb2) will not change coverage.
The diff coverage is n/a.

❗ Current head b706fce differs from pull request most recent head 02f09e4. Consider uploading reports for the commit 02f09e4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1517   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2216     2216           
  Lines      238845   238845           
  Branches     1029     1029           
=======================================
  Hits       237983   237983           
  Misses        841      841           
  Partials       21       21           

@matthewmayer matthewmayer marked this pull request as ready for review November 4, 2022 06:12
@matthewmayer matthewmayer requested a review from a team November 4, 2022 06:12
@matthewmayer matthewmayer requested a review from a team as a code owner November 4, 2022 06:12
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Nov 4, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Nov 4, 2022
ST-DDT
ST-DDT previously approved these changes Nov 5, 2022
@ST-DDT ST-DDT requested review from a team November 5, 2022 12:20
docs/guide/upgrading.md Outdated Show resolved Hide resolved
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please escape the faker method references/wrap them in code blocks? Some of the references are treated as links:

grafik

Also the link in the sidebar has the wrong title:

grafik

@matthewmayer
Copy link
Contributor Author

Could you please escape the faker method references/wrap them in code blocks? Some of the references are treated as links:

grafik

Also the link in the sidebar has the wrong title:

grafik

done

ST-DDT
ST-DDT previously approved these changes Nov 7, 2022
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested a review from a team November 20, 2022 15:41
@Shinigami92 Shinigami92 enabled auto-merge (squash) November 21, 2022 12:52
@Shinigami92 Shinigami92 merged commit 7cbeda6 into faker-js:next Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add migration guide for future v8
4 participants