Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(unsplash.avatar): deprecate #1062

Merged
merged 10 commits into from
Jun 16, 2022
Merged

chore(unsplash.avatar): deprecate #1062

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f17278f
refactor(unsplash.avatar): deprecate
xDivisionByZerox Jun 11, 2022
859012b
test(image): add unsplash avatar case
xDivisionByZerox Jun 11, 2022
dac19f3
docs(unsplash.avatar): add see jsdoc parameter
xDivisionByZerox Jun 12, 2022
33024bd
chore(unsplash.avatar): update deprecation since property
xDivisionByZerox Jun 12, 2022
89cd7b7
chore(unsplash.avatar): fix proposed
xDivisionByZerox Jun 12, 2022
4b74651
revert: test(image): add unsplash avatar case
xDivisionByZerox Jun 14, 2022
3e43b48
Merge branch 'main' into refactor/image/deprecate-unsplash-avatar
import-brain Jun 14, 2022
6a96642
chore: apply suggestions
ST-DDT Jun 14, 2022
e284fd7
Merge branch 'main' into refactor/image/deprecate-unsplash-avatar
Shinigami92 Jun 16, 2022
f26fcfa
Merge branch 'main' into refactor/image/deprecate-unsplash-avatar
Shinigami92 Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/modules/image/providers/unsplash.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { Faker } from '../../..';
import { deprecated } from '../../../internal/deprecated';

/**
* Module to generate links to random images on `https://source.unsplash.com/`.
Expand Down Expand Up @@ -30,12 +31,21 @@ export class Unsplash {
/**
* Returns a random avatar url.
*
* @see faker.internet.avatar
*
* @example
* faker.internet.avatar()
* // 'https://cloudflare-ipfs.com/ipfs/Qmd3W5DuhgHirLHGVixi6V76LhCkZUz6pnFt5AJBiyvHye/avatar/315.jpg'
*
* @deprecated
ST-DDT marked this conversation as resolved.
Show resolved Hide resolved
*/
// TODO ST-DDT 2022-03-11: Deprecate this method as it is duplicate and has nothing to do with unsplash.
avatar(): string {
deprecated({
deprecated: 'faker.image.unsplash.avatar()',
proposed: 'faker.internet.avatar()',
since: 'v7.3.0',
until: 'v8.0.0',
ST-DDT marked this conversation as resolved.
Show resolved Hide resolved
});
return this.faker.internet.avatar();
}

Expand Down