Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(unsplash.avatar): deprecate #1062

Merged
merged 10 commits into from
Jun 16, 2022
Merged

chore(unsplash.avatar): deprecate #1062

merged 10 commits into from
Jun 16, 2022

Conversation

xDivisionByZerox
Copy link
Member

Is listed in #1044.

This PR deprecates faker.image.unsplash.avatar() by m,making the following changes:

  • use internal deprecated() function
  • adding the @deprecated JSDoc parameter
  • adding a test case for the deprecation log

@xDivisionByZerox xDivisionByZerox added the p: 1-normal Nothing urgent label Jun 11, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jun 11, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team June 11, 2022 23:09
@xDivisionByZerox xDivisionByZerox self-assigned this Jun 11, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner June 11, 2022 23:09
@xDivisionByZerox
Copy link
Member Author

Is this a refactor or chore?

@xDivisionByZerox xDivisionByZerox mentioned this pull request Jun 11, 2022
Closed
@codecov
Copy link

codecov bot commented Jun 11, 2022 •
edited
Loading

Codecov Report

Merging #1062 (a448cca) into main (a448cca) will not change coverage.
The diff coverage is n/a.

❗ Current head a448cca differs from pull request most recent head e284fd7. Consider uploading reports for the commit e284fd7 to get more accurate results

@@           Coverage Diff           @@
##             main    #1062   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2135     2135           
  Lines      229160   229160           
  Branches      978      978           
=======================================
  Hits       228352   228352           
  Misses        787      787           
  Partials       21       21

@import-brain
Copy link
Member

Is this a refactor or chore?

Most of the previously merged deprecation PRs have been chore, so I'm leaning towards that.

@xDivisionByZerox xDivisionByZerox added the c: chore PR that doesn't affect the runtime behavior label Jun 11, 2022
@xDivisionByZerox xDivisionByZerox changed the title refactor(unsplash.avatar): deprecate chore(unsplash.avatar): deprecate Jun 11, 2022
ST-DDT
ST-DDT requested changes Jun 12, 2022
View reviewed changes
src/modules/image/providers/unsplash.ts Show resolved Hide resolved
src/modules/image/providers/unsplash.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Jun 12, 2022
@ST-DDT ST-DDT requested a review from a team June 12, 2022 08:58
@xDivisionByZerox xDivisionByZerox force-pushed the refactor/image/deprecate-unsplash-avatar branch from 23d9c4c to 33024bd Compare June 12, 2022 09:38
import-brain
import-brain previously approved these changes Jun 12, 2022
View reviewed changes
ST-DDT
ST-DDT previously approved these changes Jun 12, 2022
View reviewed changes
@ST-DDT ST-DDT requested review from a team June 12, 2022 15:40
Shinigami92
Shinigami92 reviewed Jun 12, 2022
View reviewed changes
test/image.spec.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 requested changes Jun 14, 2022
View reviewed changes
test/image.spec.ts Outdated Show resolved Hide resolved
import-brain
import-brain previously approved these changes Jun 14, 2022
View reviewed changes
Shinigami92
Shinigami92 previously approved these changes Jun 14, 2022
View reviewed changes
@ST-DDT ST-DDT dismissed stale reviews from Shinigami92 and import-brain via 6a96642 June 14, 2022 19:36
@ST-DDT ST-DDT requested review from a team June 14, 2022 19:36
@Shinigami92 Shinigami92 enabled auto-merge (squash) June 16, 2022 17:25
@Shinigami92 Shinigami92 merged commit 86bb94e into main Jun 16, 2022
@Shinigami92 Shinigami92 deleted the refactor/image/deprecate-unsplash-avatar branch June 16, 2022 17:39
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@xDivisionByZerox @Minozzzi
chore(unsplash.avatar): deprecate (faker-js#1062)
2d5d0db
@xDivisionByZerox xDivisionByZerox added the m: image Something is referring to the image module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain left review comments

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: chore PR that doesn't affect the runtime behavior m: image Something is referring to the image module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
4 participants
@xDivisionByZerox @import-brain @ST-DDT @Shinigami92