Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add await when saving data to be sure db is up to date when client will refresh ui #192

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

ip512
Copy link
Contributor

@ip512 ip512 commented Mar 15, 2021

This will fix some edge cases where faircalendar is not refreshed correctly after an event is added

@ip512 ip512 changed the title add await when saving data to be sure db is up to date when client will refresh ui Add await when saving data to be sure db is up to date when client will refresh ui Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #192 (64963e6) into master (72e1526) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   91.46%   91.47%           
=======================================
  Files         224      224           
  Lines        2719     2721    +2     
  Branches      142      142           
=======================================
+ Hits         2487     2489    +2     
  Misses        232      232           
Impacted Files Coverage Δ
...ion/FairCalendar/Command/AddEventCommandHandler.ts 100.00% <100.00%> (ø)
...e/Leave/Converter/LeaveRequestToLeavesConverter.ts 96.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e1526...64963e6. Read the comment docs.

@ip512 ip512 merged commit 5050b5b into master Mar 16, 2021
@ip512 ip512 deleted the fix/save-data-await branch March 16, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants