Merge pull request #192 from fairnesscoop/fix/save-data-await

Add await when saving data to be sure db is up to date when client will refresh ui
fairnesscoop · Mar 16, 2021 · 5050b5b · 5050b5b
2 parents 72e1526 + 64963e6
commit 5050b5b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/server/src/Application/FairCalendar/Command/AddEventCommandHandler.ts b/server/src/Application/FairCalendar/Command/AddEventCommandHandler.ts
@@ -41,6 +41,8 @@ export class AddEventCommandHandler extends AbstractProjectAndTaskGetter {
       this.getTask(taskId)
     ]);
 
+    const savePromises: Promise<any>[] = [];
+
     for (const day of days) {
       const date = this.dateUtils.format(day, 'y-MM-dd');
       const event = new Event(
@@ -63,9 +65,11 @@ export class AddEventCommandHandler extends AbstractProjectAndTaskGetter {
         continue;
       }
 
-      this.eventRepository.save(event);
+      savePromises.push(this.eventRepository.save(event));
     }
 
+    await Promise.all(savePromises);
+
     return new AddEventsView(errors);
   }
 

diff --git a/server/src/Domain/HumanResource/Leave/Converter/LeaveRequestToLeavesConverter.ts b/server/src/Domain/HumanResource/Leave/Converter/LeaveRequestToLeavesConverter.ts
@@ -46,7 +46,7 @@ export class LeaveRequestToLeavesConverter {
       );
     }
 
-    this.leaveRepository.save(leaves);
+    await this.leaveRepository.save(leaves);
   }
 
   private getTime(