Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with repeated values on x-axis #49

Closed
dmiklic opened this issue Jun 19, 2017 · 8 comments
Closed

Problem with repeated values on x-axis #49

dmiklic opened this issue Jun 19, 2017 · 8 comments
Labels

Comments

@dmiklic
Copy link

dmiklic commented Jun 19, 2017

A repeated value on the x-axis inhibits further plotting. This file demonstrates the issue. Upon loading the file, if I select _Column_0 as the time axis, which has identical values in rows 3 and 4, when I try to add e.g. column A to the plot area, only the first two values of A will be plotted.

My actual use case is a dataset of densely sampled (1ms) data. Occasionally, I will have two data points with the same timestamp, which is not really an issue, however, it seems to prevent PlotJuggler from correctly plotting the data.

This is with the currrent master head.

@facontidavide
Copy link
Owner

I am afraid that this time I will not be able to give you a quick fix..
The assumption of monotonic time is made in many parts of the code,being a notable example the publisher plugin.

@dmiklic
Copy link
Author

dmiklic commented Jun 19, 2017

I guess I got a bit greedy, seeing how quickly you made the other fixes. I suppose I can put some effort into cleaning my data up a bit :)

However, is there any reason this should not work on an XY plot? Because, for me it does not.

@facontidavide
Copy link
Owner

facontidavide commented Jun 19, 2017

it is really a problem of data structures. It might look as a simple feature from the outside but it will affect many parts of the code, not just the XY plot (several corner cases should be taken into account).
In other words, I am afraid I will prioritize other features, since this one requires a lot of work for a comparably small gain.

Don't hesitate anyway to ask for improvements. if I can, I am usually happy to work on them.

@dmiklic
Copy link
Author

dmiklic commented Jun 19, 2017

Sure I understand. Anyways, 2/3 fixes within 24 hours is a very decent score :)

@dmiklic
Copy link
Author

dmiklic commented Jun 21, 2017

Could we leave the issue open? I understand that It won't get fixed in the near future (or maybe ever :) and there are straightforward workarounds, but I feel like the feature itself is not unreasonable.

@facontidavide facontidavide reopened this Jun 21, 2017
@facontidavide
Copy link
Owner

of course it is not unreasonable ;)

facontidavide added a commit that referenced this issue Aug 16, 2018
@facontidavide
Copy link
Owner

One year later...

@dmiklic
Copy link
Author

dmiklic commented Aug 20, 2018

Great, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants