-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when adding data to plot loaded from ROS bag #550
Comments
if you give me a way to reproduce consistently this, I would be infinitely grateful |
I think this might fix your issue. 2ca9a91 (latest main branch) Can you please confirm? |
closing for insactivity. Feel free to open it again if problem persist in main branch |
Had some time to debug that issue. I could find an easy pattern to reproduce the crash (latest main branch):
I also got more debug output:
By debugging a bit more, I found out that PlotWidget::on_changeTimeOffset() is still being called, even if the plot widget is no longer visible, i.e. after the steps above, not two calls are being made, but rather three. This could mean that the event is not correctly disconnected, but I don't know much about Qt event handling. Doing some print debugging it was clear that ~DockWidget() and ~QwtPlotPimpl() is being called, but not ~PlotWidget(). A simple fix for this was adding a delete call to DockWidget: I will do a pull request if no other issues pop up. But I think this delete call maybe masks the real issue, such that somehow the created XY curve holds a reference to the PlotWidget. |
thanks, this really helps a lot. @henrik1235 I appreciate a lot that you investigated this yourself and found a solution |
i found the signel:valueChange will invoke all plot widget even we close someone;but when we close a plot widget.it seem that DockWidget won |
The previous was not a solution, but this is: 7a0df31 |
On my system PlotJuggler sometimes crashes when simply adding data to plots. I have multiple plots of which some are X/Y plots. Everything works fine, but after some time when I add new data or load another ROS bag, then PlotJuggler simply crashes. See the attached stack trace.
My system:
The text was updated successfully, but these errors were encountered: