Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4.0.0 #176

Merged
merged 21 commits into from
Feb 22, 2019
Merged

V4.0.0 #176

merged 21 commits into from
Feb 22, 2019

Conversation

ScriptedAlchemy
Copy link
Collaborator

No description provided.

re6exp and others added 19 commits September 4, 2018 19:39
@re6exp
#129
8a3bd2b
@re6exp
\#129
527adca
@re6exp
Merge branch 'migrate-to-api-16' of https://github.com/re6exp/react-u…
f99ec64 
…niversal-component into migrate-to-api-16
@re6exp
Change getDerivedStateFromProps to componentDidUpdate
d56fb06
@re6exp
Change getDerivedStateFromProps to componentDidUpdate
8694ddb
@re6exp
Some little fixes.
7ca3c30
@re6exp
HMR now works
f48a22e
@re6exp
All errors fixed. All tests run successfull. Before polishing.
b98f71a
@re6exp
Polish
8e2ce88
@ScriptedAlchemy
Moving chunk name resolution back to slashes
8c930fa
@ScriptedAlchemy
new 4v branch
7810657
@ScriptedAlchemy
Merge pull request #149 from re6exp/migrate-to-api-16
b7ee921 
feat: React 16 API Implementation
@ScriptedAlchemy
Merge branch 'master' into v4.0.0
039d80f 
# Conflicts:
#	src/flowTypes.js
#	src/requireUniversalModule.js
@ScriptedAlchemy
merges and bumping version
da1e786
@ScriptedAlchemy
adding codeowners
a44bd6f
@ScriptedAlchemy
usesBabelPlugin added back
d45bce7
@ScriptedAlchemy
feat: Updated RUC to react 16.3 and up
642d459 
Moving away from deprecated willMount and to the non-deprecated lifecycle

BREAKING CHANGE: Only Compatible with React 16.3 and up

fix #129
@ScriptedAlchemy
fix: ignore babel rename by default
23e75f5
@ScriptedAlchemy
Merge branch 'react16' into v4.0.0
b151ecb
@ScriptedAlchemy ScriptedAlchemy mentioned this pull request Jan 28, 2019
Closed
@jaybe78
Copy link

jaybe78 commented Feb 6, 2019

Hey @ScriptedAlchemy
Sorry for the delay, I've been swamped + got distracted by npm issue webpack/webpack#8656

Anyway, I've pulled your branch and used it in my project, all LGTM ! 👍
I've even upgraded to babel 7, it all works smoothly.
Will do a couple of more test throughout the days.

@ScriptedAlchemy ScriptedAlchemy merged commit 3c21ffa into master Feb 22, 2019
@erykpiast
Copy link

Hey @ScriptedAlchemy, where may I find changelog or migration guide for this version? It was major upgrade, so I assume there is some code update reqiuired on my side...?

@jaybe78
Copy link

jaybe78 commented Feb 26, 2019

@erykpiast The migration is seamless, It works as such. You should not need to change anything in your code.

@ScriptedAlchemy
Copy link
Collaborator Author

Yep it’s a clean upgrade. Just the underlying React api is completely new (no more componentWillMount)

@marnusw
Copy link

marnusw commented Mar 7, 2019

@ScriptedAlchemy would you mind just adding a note about it being a clean upgrade in the GitHub Releases section? I was hesitant to upgrade myself until I hunted down this PR.

@ScriptedAlchemy
Copy link
Collaborator Author

Will do. Usually rely on the releases section to communicate this. I’ll update it today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScriptedAlchemy @jaybe78 @erykpiast @marnusw @re6exp