-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React16 API #156
React16 API #156
Conversation
…niversal-component into migrate-to-api-16
feat: React 16 API Implementation
@ScriptedAlchemy When do you plan to release this ? |
You tell me it’s stable. And I’ll release a flag tonight on NPM for you. Then roll it as a major release in a few days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this seems easier to follow than before.
Since getDerivedStateFromProps
is only available in React 16.3, the peerDependency on react should probably be changed from *
to ^16.3.0
.
@ScriptedAlchemy I'm using it in my project. It is stable |
@jaybe78 anything you'd like to PR into it, take a look at the branch and then I'll give it a final brush, merge, and major release. @GuillaumeCisco is there any way we can collab on this and make it one major release for both redux 6 and react 17? |
@ScriptedAlchemy Would be nice to upgrade to babel 7 as well as part of that change. I did it in my branch, it's a seamless change: https://github.com/jaybe78/react-universal-component/blob/master/package.json |
@ScriptedAlchemy, thanks for poking me towards this issue. |
@ScriptedAlchemy Hello, any progress on this one ? |
Okay, i can merge this, Do you want to open a PR for babel 7? I dont mind moving to that and have done so in some places, this will be a major release |
@jaybe78 thanks for bumping this, ill merge it tomorrow. If i dont, bump it again - hold me to it. Squeaky wheel gets the grease and i oversee many projects |
@ScriptedAlchemy hehe don't worry I will be a pain in the ass until you merge it. I will create PR for babel 7. Thanks :) |
Got some build errors I’m addressing, should merge it tomorrow /: |
PR opened here. some additional changes need to go in |
@jaybe78 One last time, will you try the released alpha I put up yesterday Fixed the build issues so I'm ready to merge |
@ScriptedAlchemy Will check it today, I'll get back to you ASAP. Thanks! |
Thanks I’ll merge if ur happy |
Merged via another PR which had other various updates |
on npm as
@react16
This is a breaking change