Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React16 API #156

Closed
wants to merge 10 commits into from
Closed

React16 API #156

wants to merge 10 commits into from

Conversation

ScriptedAlchemy
Copy link
Collaborator

on npm as @react16

This is a breaking change

@ScriptedAlchemy ScriptedAlchemy self-assigned this Sep 17, 2018
@jaybe78
Copy link

jaybe78 commented Jan 4, 2019

@ScriptedAlchemy When do you plan to release this ?

@ScriptedAlchemy
Copy link
Collaborator Author

You tell me it’s stable. And I’ll release a flag tonight on NPM for you. Then roll it as a major release in a few days

Copy link

@hedgepigdaniel hedgepigdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this seems easier to follow than before.

Since getDerivedStateFromProps is only available in React 16.3, the peerDependency on react should probably be changed from * to ^16.3.0.

@jaybe78
Copy link

jaybe78 commented Jan 5, 2019

@ScriptedAlchemy I'm using it in my project. It is stable

@ScriptedAlchemy
Copy link
Collaborator Author

@jaybe78 anything you'd like to PR into it, take a look at the branch and then I'll give it a final brush, merge, and major release.

@GuillaumeCisco is there any way we can collab on this and make it one major release for both redux 6 and react 17?

@jaybe78
Copy link

jaybe78 commented Jan 7, 2019

@ScriptedAlchemy Would be nice to upgrade to babel 7 as well as part of that change. I did it in my branch, it's a seamless change: https://github.com/jaybe78/react-universal-component/blob/master/package.json
Other than that il all looks good and ready to be merged.
Thanks

@GuillaumeCisco
Copy link

GuillaumeCisco commented Jan 7, 2019

@ScriptedAlchemy, thanks for poking me towards this issue.
As I explained in #172, we should only document the way users should work with [email protected] as the redux store will not be available the same way.

@jaybe78
Copy link

jaybe78 commented Jan 15, 2019

@ScriptedAlchemy Hello, any progress on this one ?

@ScriptedAlchemy
Copy link
Collaborator Author

Okay, i can merge this, Do you want to open a PR for babel 7? I dont mind moving to that and have done so in some places, this will be a major release

@ScriptedAlchemy
Copy link
Collaborator Author

@jaybe78 thanks for bumping this, ill merge it tomorrow. If i dont, bump it again - hold me to it. Squeaky wheel gets the grease and i oversee many projects

@jaybe78
Copy link

jaybe78 commented Jan 25, 2019

@ScriptedAlchemy hehe don't worry I will be a pain in the ass until you merge it. I will create PR for babel 7. Thanks :)

@ScriptedAlchemy
Copy link
Collaborator Author

Got some build errors I’m addressing, should merge it tomorrow /:

@ScriptedAlchemy
Copy link
Collaborator Author

PR opened here. some additional changes need to go in
#176

@ScriptedAlchemy
Copy link
Collaborator Author

[email protected]

@ScriptedAlchemy
Copy link
Collaborator Author

@jaybe78 One last time, will you try the released alpha I put up yesterday

Fixed the build issues so I'm ready to merge

@jaybe78
Copy link

jaybe78 commented Jan 30, 2019

@ScriptedAlchemy Will check it today, I'll get back to you ASAP. Thanks!

@ScriptedAlchemy
Copy link
Collaborator Author

Thanks I’ll merge if ur happy

@ScriptedAlchemy
Copy link
Collaborator Author

Merged via another PR which had other various updates

@ScriptedAlchemy ScriptedAlchemy deleted the react16 branch January 19, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants