Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hardware test place #65

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add hardware test place #65

merged 1 commit into from
Aug 30, 2023

Conversation

KavitShah1998
Copy link
Contributor

No description provided.

@KavitShah1998 KavitShah1998 self-assigned this Aug 10, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 10, 2023
@KavitShah1998 KavitShah1998 marked this pull request as draft August 10, 2023 01:15
@KavitShah1998 KavitShah1998 changed the title Add hardware test place [DRAFT] Add hardware test place Aug 10, 2023
@KavitShah1998 KavitShah1998 requested review from akshararai and jimmytyyang and removed request for akshararai August 11, 2023 20:47
jimmytyyang
jimmytyyang reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kavit, thanks for this! I left some comments, and overall the PR looks great!

spot_rl_experiments/spot_rl/envs/place_env.py Outdated Show resolved Hide resolved
tests/hardware_tests/test_place_env.py Outdated Show resolved Hide resolved
tests/hardware_tests/configs/waypoints.yaml Outdated Show resolved Hide resolved
tests/hardware_tests/configs/waypoints.yaml Outdated Show resolved Hide resolved
@KavitShah1998 KavitShah1998 changed the title [DRAFT] Add hardware test place Add hardware test place Aug 18, 2023
@KavitShah1998 KavitShah1998 marked this pull request as ready for review August 18, 2023 01:25
jimmytyyang
jimmytyyang reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

bd_spot_wrapper/spot_wrapper/spot.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/envs/place_env.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/envs/place_env.py Show resolved Hide resolved
spot_rl_experiments/spot_rl/envs/place_env.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/envs/place_env.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/envs/place_env.py Show resolved Hide resolved
akshararai
akshararai reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@akshararai akshararai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, lets chat about them

spot_rl_experiments/spot_rl/envs/mobile_manipulation_env.py Show resolved Hide resolved
spot_rl_experiments/spot_rl/envs/place_env.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/envs/place_env.py Show resolved Hide resolved
spot_rl_experiments/spot_rl/envs/base_env.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/envs/place_env.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/geometry_utils.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/geometry_utils.py Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/geometry_utils.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/geometry_utils.py Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/geometry_utils.py Outdated Show resolved Hide resolved
akshararai
akshararai approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@akshararai akshararai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good! thank you so much for working on this! :)

spot_rl_experiments/spot_rl/envs/base_env.py Show resolved Hide resolved
jimmytyyang
jimmytyyang approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KavitShah1998 KavitShah1998 merged commit 37ee6b0 into main Aug 30, 2023
1 check passed
@KavitShah1998 KavitShah1998 deleted the add_hardware_test_place branch August 30, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshararai akshararai akshararai approved these changes

@jimmytyyang jimmytyyang Awaiting requested review from jimmytyyang

Assignees

@KavitShah1998 KavitShah1998

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KavitShah1998 @akshararai @jimmytyyang @facebook-github-bot