Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Fix field initialization order breaking clang #293

Closed
wants to merge 1 commit into from
Closed

Fix field initialization order breaking clang #293

wants to merge 1 commit into from

Conversation

xmakro
Copy link

@xmakro xmakro commented Dec 7, 2021

No description provided.

@facebook-github-bot
Copy link

Hi @makroiss!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@xmakro xmakro changed the title Fix field initialization order breaking Fix field initialization order breaking clang Dec 7, 2021
@heiner heiner self-requested a review December 7, 2021 15:25
@heiner
Copy link
Contributor

heiner commented Dec 7, 2021

Hey Makro! Thanks for your contribution to NLE!

Could you please sign the CLA (might require approval from your employer) and run clang-format, version 11 on your code or otherwise fix https://github.com/facebookresearch/nle/runs/4445827015?check_suite_focus=true?

heiner pushed a commit that referenced this pull request Dec 16, 2021
heiner pushed a commit that referenced this pull request Dec 16, 2021
heiner pushed a commit that referenced this pull request Dec 16, 2021
@xmakro xmakro closed this Dec 16, 2021
@xmakro xmakro reopened this Dec 16, 2021
@xmakro xmakro closed this Dec 16, 2021
heiner pushed a commit that referenced this pull request Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants