Fix #293, enable compiler warnings in debug mode.

facebookresearch · Dec 16, 2021 · aaa7d9a · aaa7d9a
1 parent d325cf1
commit aaa7d9a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -19,6 +19,13 @@ if(CMAKE_BUILD_TYPE MATCHES Debug)
         "${CMAKE_LINKER_FLAGS_DEBUG} -fno-omit-frame-pointer -fsanitize=address"
     )
   endif()
+  if(MSVC)
+    # warning level 4 and all warnings as errors
+    add_compile_options(/W4 /WX)
+  else()
+    # lots of warnings and all warnings as errors
+    add_compile_options(-Wall)
+  endif()
 elseif(CMAKE_BUILD_TYPE MATCHES Release)
   message("Release build.")
 else()

diff --git a/win/rl/pynethack.cc b/win/rl/pynethack.cc
@@ -61,9 +61,8 @@ class Nethack
 {
   public:
     Nethack(std::string dlpath, std::string ttyrec, bool spawn_monsters)
-        : dlpath_(std::move(dlpath)), obs_{},
-          ttyrec_(std::fopen(ttyrec.c_str(), "a")),
-          spawn_monsters_(spawn_monsters)
+        : dlpath_(std::move(dlpath)), obs_{}, spawn_monsters_(spawn_monsters),
+          ttyrec_(std::fopen(ttyrec.c_str(), "a"))
     {
         if (!ttyrec_) {
             PyErr_SetFromErrnoWithFilename(PyExc_OSError, ttyrec.c_str());