This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Rollback dispatch patch #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 26, 2019 11:14
…rk with conflicts.
# Conflicts: # maskrcnn_benchmark/csrc/cuda/SigmoidFocalLoss_cuda.cu
facebook-github-bot
added
the
CLA Signed
|
cc @fmassa |
|
cc @vishwakftw I believe this can be reverted now, given that there was a backward-compatibility fix sent to PyTorch? |
|
Also note that this will be introducing deprecation warnings during compilation time pytorch/pytorch#17996 |
vishwakftw
approved these changes
Mar 26, 2019
eskjorg
pushed a commit
to eskjorg/maskrcnn-benchmark
that referenced
this pull request
Mar 27, 2019
* Merge branch 'master' of /home/braincreator/projects/maskrcnn-benchmark with conflicts. * rolls back the breaking AT dispatch changes (facebookresearch#555) * revert accidental docker changes * revert accidental docker changes (2)
Lyears
pushed a commit
to Lyears/maskrcnn-benchmark
that referenced
this pull request
Jun 28, 2020
* Merge branch 'master' of /home/braincreator/projects/maskrcnn-benchmark with conflicts. * rolls back the breaking AT dispatch changes (facebookresearch#555) * revert accidental docker changes * revert accidental docker changes (2)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts AT_DISPATCH_FLOATING_TYPES patch, which lead to a compilation error with the latest version of pytorch and pytorch-nightly
FIxes #601