Fix dispatch breakage

[vishwakftw]

@fmassa This fixes the dispatch breakage introduced by pytorch/pytorch@3aeb780.

Closes pytorch/pytorch#17861

[facebook-github-bot]

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status.

[fmassa]

Thanks!

But I suppose that we need now to ask users to use PyTorch from source, or else it will break for those who are using PyTorch 1.0, or 1.0.1, right?

[vishwakftw]

The installation instructions suggested to use the nightly build, which is why I sent in a PR.

[fmassa]

That used to be the case, but we have since #510 changed it to install from a pinned version.

Something should be changed, here are a few possibilities:

• change the install instructions to install from a nightly, and add a big warning there saying that this repo doesn't work with 1.0 or 1.0.1
• revert this patch and keep this repo only working on a pinned version of PyTorch
• find a better solution

[fmassa]

As it turns out, #510 had a bugged install anyway, so I'll be reverting parts of it, and in the meantime I'll also make it work only on a nightly version

[vishwakftw]

Oh I'm sorry I didn't see the installation snippet. The first line in INSTALL.md seems to be misleading.

[fmassa]

@vishwakftw I'll fix the installation instructions, don't worry, they are bugged now anyway :-D

[vishwakftw]

Thank you, and sorry about the confusion.

[fmassa]

No worries, thanks for fixing this issue so quickly!

[drcege]

@vishwakftw I'll fix the installation instructions, don't worry, they are bugged now anyway :-D

@fmassa
The first line of Installation/Requirements (PyTorch 1.0 from a nightly release) is still misleading.
The nightly release is now PyTorch 1.2 (am I right?). And README also said the project is using PyTorch 1.0.

By the way, are Dockerfiles up to date?