Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize subtests in test_download_logs.py #995

Closed
wants to merge 21 commits into from
Closed

Utilize subtests in test_download_logs.py #995

wants to merge 21 commits into from

Commits on Jun 2, 2022

  1. Fix pyre in download_logs/ 

    Differential Revision: D36812809

fbshipit-source-id: 2e1905f52b676e094e278545cfc00518fd62fe58
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    a93241c View commit details
    Browse the repository at this point in the history

  2. Add test file for download_logs 

    Differential Revision: D36812973

fbshipit-source-id: b2f4d2774eb79a61d844ca68c0ab20d16d00f6e0
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    38efd8f View commit details
    Browse the repository at this point in the history

  3. Add skeleton code to test other methods 

    Differential Revision: D36813021

fbshipit-source-id: bc9c6b765b4af68d3485574d97ea56b4a841dd72
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    9752ddf View commit details
    Browse the repository at this point in the history

  4. Add test for get_cloudwatch_logs 

    Differential Revision: D36818860

fbshipit-source-id: bbe012558a14bde0f3b34443f1fef008485df27f
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    a82445f View commit details
    Browse the repository at this point in the history

  5. Add tests for exception cases of get_cloudwatch_logs 

    Differential Revision: D36819724

fbshipit-source-id: 2211b7aa7918d1cbbaa436fc71344edc9d2ba0b4
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    190e10f View commit details
    Browse the repository at this point in the history

  6. Add tests for parse_container_arn 

    Differential Revision: D36819989

fbshipit-source-id: fbd5fb61ab22a0c8a82991801617fb1bedba8a93
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5985ccf View commit details
    Browse the repository at this point in the history

  7. Add tests for parse_log_events 

    Differential Revision: D36820121

fbshipit-source-id: d7754ab9470dab7112455b6a7fa413d7051750c2
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    83cec90 View commit details
    Browse the repository at this point in the history

  8. Add tests for parse_get_container_name_id 

    Differential Revision: D36820489

fbshipit-source-id: f1a495e1ea2428a685f8760190567e7904716c58
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    f1f0a5d View commit details
    Browse the repository at this point in the history

  9. Add tests for verify_log_group 

    Differential Revision: D36821853

fbshipit-source-id: 0d69577ead688d297c4ccd806495348ff38b8e96
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    936bcbd View commit details
    Browse the repository at this point in the history

  10. Add tests for verify_log_stream 

    Differential Revision: D36822211

fbshipit-source-id: 7e3a9da68030515bdd2d2f634d70ddb8eaae82cf
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    05d6a90 View commit details
    Browse the repository at this point in the history

  11. Add tests for create_s3_folder 

    Differential Revision: D36822544

fbshipit-source-id: 0a61fc9fd6f98564357a261682ef0fd63a7b264e
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    745c3e5 View commit details
    Browse the repository at this point in the history

  12. Add tests for get_s3_folder_contents 

    Differential Revision: D36822905

fbshipit-source-id: 24f1db4c7fde04f98571f6d568282d218ed94fc6
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    c7970b4 View commit details
    Browse the repository at this point in the history

  13. Add tests for ensure_folder_exists 

    Differential Revision: D36823014

fbshipit-source-id: 0b7103828b7f1c64fe7124928c250d45800de13d
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    7881854 View commit details
    Browse the repository at this point in the history

  14. Add tests for get_s3_folder_path 

    Differential Revision: D36823145

fbshipit-source-id: d72966d70eb2a1a04ee6e62c09d0ebaeb490d110
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    a9a8fc1 View commit details
    Browse the repository at this point in the history

  15. Add tests for get_files_to_download_logs 

    Differential Revision: D36826670

fbshipit-source-id: 9b7dd7fc21271e510610775dd00fc17a73597a26
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    49a71af View commit details
    Browse the repository at this point in the history

  16. Add tests for download_logs 

    Differential Revision: D36828619

fbshipit-source-id: c8b952ed471c237b651b925fefc451b172a48133
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    8d55138 View commit details
    Browse the repository at this point in the history

  17. Add tests for upload_logs_to_s3_from_cloudwatch 

    Differential Revision: D36836489

fbshipit-source-id: 9bbc226e638daf8734fb1824e7de825608fcf392
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    9508fc1 View commit details
    Browse the repository at this point in the history

  18. Reorganize file to have public API before private helpers 

    Differential Revision: D36861913

fbshipit-source-id: 12a474476628b164862dabe9853a2c4f0f4bd342
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    1edbdd4 View commit details
    Browse the repository at this point in the history

  19. Add pyre-strict to test_download_logs.py 

    Differential Revision: D36861981

fbshipit-source-id: 7068cc204cfb03e27007fc06e0a3a64fcd2ec0cd
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    6af6fa3 View commit details
    Browse the repository at this point in the history

  20. Link tasks to each TODO in download_logs.py 

    Differential Revision: D36863598

fbshipit-source-id: 051253eded9ce58a79ec972dcd09cf2727f7bee5
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    f34f153 View commit details
    Browse the repository at this point in the history

  21. Utilize subtests in test_download_logs.py (facebookresearch#995) 

    Summary:
Pull Request resolved: facebookresearch#995

# This stack:
* Adding tests for download_logs/
# This diff:
* I know it looks scary, but the vast majority of it is just tabbing...
* Every test is split into multiple sub-tests as per marksliva's recommendation in [this comment](https://www.internalfb.com/diff/D36819724?dst_version_fbid=1118320549024875&transaction_fbid=532330348543619).

Reviewed By: marksliva

Differential Revision:
D36863858

LaMa Project: L1089718

fbshipit-source-id: d42a423f758102c58ef86b9bf0b023cac4bf2876
    @facebook-github-bot
    Logan Gore authored and facebook-github-bot committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5160821 View commit details
    Browse the repository at this point in the history