Utilize subtests in test_download_logs.py #995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D36863858 |
gorel
pushed a commit
to gorel/fbpcs
that referenced
this pull request
Jun 2, 2022
Summary: Pull Request resolved: facebookresearch#995 # This stack: * Adding tests for download_logs/ # This diff: * I know it looks scary, but the vast majority of it is just tabbing... * Every test is split into multiple sub-tests as per marksliva's recommendation in [this comment](https://www.internalfb.com/diff/D36819724?dst_version_fbid=1118320549024875&transaction_fbid=532330348543619). Differential Revision: D36863858 LaMa Project: L1089718 fbshipit-source-id: d6b5377488a8626171069bee647d6de8286c0958
|
This pull request was exported from Phabricator. Differential Revision: D36863858 |
added 21 commits
June 2, 2022 09:21
Differential Revision: D36812809 fbshipit-source-id: 2e1905f52b676e094e278545cfc00518fd62fe58
Differential Revision: D36812973 fbshipit-source-id: b2f4d2774eb79a61d844ca68c0ab20d16d00f6e0
Differential Revision: D36813021 fbshipit-source-id: bc9c6b765b4af68d3485574d97ea56b4a841dd72
Differential Revision: D36818860 fbshipit-source-id: bbe012558a14bde0f3b34443f1fef008485df27f
Differential Revision: D36819724 fbshipit-source-id: 2211b7aa7918d1cbbaa436fc71344edc9d2ba0b4
Differential Revision: D36819989 fbshipit-source-id: fbd5fb61ab22a0c8a82991801617fb1bedba8a93
Differential Revision: D36820121 fbshipit-source-id: d7754ab9470dab7112455b6a7fa413d7051750c2
Differential Revision: D36820489 fbshipit-source-id: f1a495e1ea2428a685f8760190567e7904716c58
Differential Revision: D36821853 fbshipit-source-id: 0d69577ead688d297c4ccd806495348ff38b8e96
Differential Revision: D36822211 fbshipit-source-id: 7e3a9da68030515bdd2d2f634d70ddb8eaae82cf
Differential Revision: D36822544 fbshipit-source-id: 0a61fc9fd6f98564357a261682ef0fd63a7b264e
Differential Revision: D36822905 fbshipit-source-id: 24f1db4c7fde04f98571f6d568282d218ed94fc6
Differential Revision: D36823014 fbshipit-source-id: 0b7103828b7f1c64fe7124928c250d45800de13d
Differential Revision: D36823145 fbshipit-source-id: d72966d70eb2a1a04ee6e62c09d0ebaeb490d110
Differential Revision: D36826670 fbshipit-source-id: 9b7dd7fc21271e510610775dd00fc17a73597a26
Differential Revision: D36828619 fbshipit-source-id: c8b952ed471c237b651b925fefc451b172a48133
Differential Revision: D36836489 fbshipit-source-id: 9bbc226e638daf8734fb1824e7de825608fcf392
Differential Revision: D36861913 fbshipit-source-id: 12a474476628b164862dabe9853a2c4f0f4bd342
Differential Revision: D36861981 fbshipit-source-id: 7068cc204cfb03e27007fc06e0a3a64fcd2ec0cd
Differential Revision: D36863598 fbshipit-source-id: 051253eded9ce58a79ec972dcd09cf2727f7bee5
Summary: Pull Request resolved: facebookresearch#995 # This stack: * Adding tests for download_logs/ # This diff: * I know it looks scary, but the vast majority of it is just tabbing... * Every test is split into multiple sub-tests as per marksliva's recommendation in [this comment](https://www.internalfb.com/diff/D36819724?dst_version_fbid=1118320549024875&transaction_fbid=532330348543619). Reviewed By: marksliva Differential Revision: D36863858 LaMa Project: L1089718 fbshipit-source-id: d42a423f758102c58ef86b9bf0b023cac4bf2876
|
This pull request was exported from Phabricator. Differential Revision: D36863858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This stack:
This diff:
Differential Revision:
D36863858
LaMa Project: L1089718