Add antlr4-runtime-cpp installation in setup scripts #7449
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #7417 PrestoDB has a parseTypeSignature API,
which can parse a type string to a Velox type. However, we do
not have this kind of API in Velox. To add this parser, we need
to have antlr4-cpp-runtime first. Use the same way in PrestoDB
to add antlr4 through setup scripts, such as
function install_antlr4
in https://github.com/prestodb/presto/blob/master/presto-native-execution/scripts/setup-ubuntu.sh#L48