Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Native] Use Flex/Bison to parse types and remove dependency on antlr4 runtime #21334

Closed
majetideepak opened this issue Nov 7, 2023 · 1 comment · Fixed by #21357
Closed

[Native] Use Flex/Bison to parse types and remove dependency on antlr4 runtime #21334

majetideepak opened this issue Nov 7, 2023 · 1 comment · Fixed by #21357
Labels
feature request

Comments

@majetideepak
Copy link
Collaborator

Prestissimo parses types in PrestoToVeloxQueryPlan using antlr4.
Parsing types can also be implemented using Flex/Bison.
We already use Flex/Bison to compute decimal precision/scale values in Velox.
This helps remove the dependency on antlr4 runtime.
@majetideepak majetideepak mentioned this issue Nov 7, 2023
Closed
@majetideepak majetideepak changed the title [Native] Use Flex/Bison to parse types and remove dependency on antrl4 runtime [Native] Use Flex/Bison to parse types and remove dependency on antlr4 runtime Nov 8, 2023
@majetideepak
Copy link
Collaborator Author

Another option is to extend the Velox HiveTypeParser. See discussion here facebookincubator/velox#7502

@majetideepak majetideepak mentioned this issue Dec 7, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[native] Use Velox::TypeParser instead of Antlr and remove Antlr majetideepak/presto
1 participant
@majetideepak