Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for Window in deepFreeze #1571

Closed
wants to merge 1 commit into from
Closed

Add check for Window in deepFreeze #1571

wants to merge 1 commit into from

Conversation

mondaychen
Copy link
Contributor

Fixes #904

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2022
@facebook-github-bot
Copy link
Contributor

@mondaychen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mondaychen mondaychen mentioned this pull request Jan 27, 2022
Closed
@drarmstr drarmstr added the bug Something isn't working label Jan 29, 2022
@drarmstr drarmstr linked an issue Jan 29, 2022 that may be closed by this pull request
Compilation for Vite.js #509
Closed
AlexGuz23 pushed a commit to AlexGuz23/Recoil that referenced this pull request Nov 3, 2022
@jackwolfskin0302 @facebook-github-bot
Add check for Window in deepFreeze (#1571)
c6dc384 
Summary:
Fixes facebookexperimental/Recoil#904

Pull Request resolved: facebookexperimental/Recoil#1571

Reviewed By: drarmstr

Differential Revision: D33829687

Pulled By: mondaychen

fbshipit-source-id: 93a891d87d956c83eda2c102f84868b0a6cffae3
snipershooter0701 added a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
@snipershooter0701 @facebook-github-bot
Add check for Window in deepFreeze (#1571)
5bdf9aa 
Summary:
Fixes facebookexperimental/Recoil#904

Pull Request resolved: facebookexperimental/Recoil#1571

Reviewed By: drarmstr

Differential Revision: D33829687

Pulled By: mondaychen

fbshipit-source-id: 93a891d87d956c83eda2c102f84868b0a6cffae3
eagle2722 added a commit to eagle2722/Recoil that referenced this pull request Sep 21, 2024
@eagle2722
Add check for Window in deepFreeze (#1571)
2da3adb 
Summary:
Fixes facebookexperimental/Recoil#904

Pull Request resolved: facebookexperimental/Recoil#1571

Reviewed By: drarmstr

Differential Revision: D33829687

Pulled By: mondaychen

fbshipit-source-id: 93a891d87d956c83eda2c102f84868b0a6cffae3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mondaychen mondaychen

Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReferenceError: Window is not defined, shouldNotBeFrozen Compilation for Vite.js
3 participants
@mondaychen @facebook-github-bot @drarmstr