Add check for Window in deepFreeze (#1571)

Summary: Fixes facebookexperimental/Recoil#904 Pull Request resolved: facebookexperimental/Recoil#1571 Reviewed By: drarmstr Differential Revision: D33829687 Pulled By: mondaychen fbshipit-source-id: 93a891d87d956c83eda2c102f84868b0a6cffae3
AlexGuz23 · Feb 2, 2022 · c6dc384 · c6dc384
1 parent 9d89b4f
commit c6dc384
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 **_Add new changes here as they land_**
 
+- `shouldNotBeFrozen` now works in JS environment without `Window` interface. (#1571)
+
 ## 0.6.1 (2022-01-29)
 
 - Fix postInstall script (#1577)

diff --git a/packages/shared/util/Recoil_Environment.js b/packages/shared/util/Recoil_Environment.js
@@ -10,11 +10,21 @@
  */
 'use strict';
 
-const isSSR: boolean = typeof window === 'undefined';
+const isSSR: boolean =
+  // $FlowFixMe(site=recoil) Window does not have a FlowType definition https://github.com/facebook/flow/issues/6709
+  // eslint-disable-next-line fb-www/typeof-undefined
+  typeof Window === 'undefined' || typeof window === 'undefined';
+
+const isWindow = (value: mixed): boolean =>
+  !isSSR &&
+  // $FlowFixMe(site=recoil) Window does not have a FlowType definition https://github.com/facebook/flow/issues/6709
+  (value === window || value instanceof Window);
+
 const isReactNative: boolean =
   typeof navigator !== 'undefined' && navigator.product === 'ReactNative'; // eslint-disable-line fb-www/typeof-undefined
 
 module.exports = {
   isSSR,
   isReactNative,
+  isWindow,
 };
diff --git a/packages/shared/util/Recoil_deepFreezeValue.js b/packages/shared/util/Recoil_deepFreezeValue.js
@@ -14,7 +14,7 @@
  */
 'use strict';
 
-const {isReactNative, isSSR} = require('./Recoil_Environment');
+const {isReactNative, isWindow} = require('./Recoil_Environment');
 const isNode = require('./Recoil_isNode');
 const isPromise = require('./Recoil_isPromise');
 
@@ -61,12 +61,7 @@ function shouldNotBeFrozen(value: mixed): boolean {
   }
 
   // Some environments, just as Jest, don't work with the instanceof check
-  if (
-    !isSSR &&
-    !isReactNative &&
-    // $FlowFixMe(site=recoil) Window does not have a FlowType definition https://github.com/facebook/flow/issues/6709
-    (value === window || value instanceof Window)
-  ) {
+  if (!isReactNative && isWindow(value)) {
     return true;
   }