Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

handle scrolling by Y nodePosition #775

Closed
wants to merge 2 commits into from

Conversation

michelson
Copy link

@michelson michelson commented Nov 9, 2016

TODO:

  • fix 1 failing spec

Summary

tackles issue #304

Test Plan

When you have a big paragraph and you press enter in the middle, instead of keeping the focus in the middle of the page, the editor scrolls all the way to the bottom.

Steps to reproduce bug in current draft :

  • Go to https://facebook.github.io/draft-js/
  • Copy paste in a large continuous paragraph without any newlines in between.
  • Scroll to the middle of the big paragraph and press enter.
  • The editor will have scrolled to the bottom
  • This doesn't seem to happen consistently all the time, but I've seen it come up enough times on big paragraphs.

@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rezaaa
Copy link

rezaaa commented Feb 20, 2017

What happened to this issue?

@dtmunir
Copy link

dtmunir commented Mar 14, 2017

+1 on getting this reviewed and merged

@erisnuts
Copy link

+1

@niveditc
Copy link
Contributor

Superseded by #1223 which seems to have a better fix as per the discussion on #304. Waiting for conflicts to be resolved to merge in #1223, and closing this PR.

@niveditc niveditc closed this Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants