Fix Bug 304 - Editor scrolls to bottom when pressing enter in the mid… #1223
Conversation
…dle of a big paragraph
|
We are facing this same issue, however, I needed to factor the @andpor Did you encounter that as well? |
|
@bradbumbalough no I did not have this issue. What is the use case where this is failing so I can check as well on my side. I can't believe this PR is still not merged.... |
|
Can someone form Facebook explain why the PR has not yet been merged. This is a serious showstopper issue. PR has been opened since May 27 - this is 4 months already. |
|
@andpor @jackyho112 The issue has not been fixed with the overflow: auto, unfortunately. The changes in this PR does. Is anyone still looking in to this? Can this be merged? It's a one-liner and it does fix the issues described in #304. Anyhow, it would make a whole lot of people happy if this could be resolved :) |
|
Still an issue as at 0.10.5 - any plans to merge this PR? |
|
Hey folks! Apologies for the delay in merging this PR. @andpor - can you rebase on master & fix the conflicts. Then I'll merge it in :) |
|
@andpor - just wanted to ping this! I'd be happy to merge it in once the conflicts have been fixed. |
|
After 2 years ??????? Really amazing.... |
|
I think I resolved conflicts - please double check and merge. |
|
@niveditc - please let me know what needs to be done to have this merged... |
After 2 years...... hope to merge this PR as soon as possibile |
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@andpor thanks for rebasing, importing to check it out. |
|
What else needs to be done for this PR to get merged? |
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
What is going on with this PR ? |
|
@andpor It's seems some lint error caused the Travis CI build failed,can you fix it. |
Summary: Should fix #304. Thanks andpor. **Summary** based on Andrzej's #1223, issue has been there for an incredible 3.5 years. Let's fix this. Pull Request resolved: #2197 Reviewed By: elboman Differential Revision: D18314441 Pulled By: mrkev fbshipit-source-id: 99284101bab838c574341b44b3cfcd935f1dc0e2
|
Fixed in #2197 |
Summary: Should fix facebookarchive#304. Thanks andpor. **Summary** based on Andrzej's facebookarchive#1223, issue has been there for an incredible 3.5 years. Let's fix this. Pull Request resolved: facebookarchive#2197 Reviewed By: elboman Differential Revision: D18314441 Pulled By: mrkev fbshipit-source-id: 99284101bab838c574341b44b3cfcd935f1dc0e2
Summary: Should fix facebookarchive#304. Thanks andpor. **Summary** based on Andrzej's facebookarchive#1223, issue has been there for an incredible 3.5 years. Let's fix this. Pull Request resolved: facebookarchive#2197 Reviewed By: elboman Differential Revision: D18314441 Pulled By: mrkev fbshipit-source-id: 99284101bab838c574341b44b3cfcd935f1dc0e2
Summary
Fixes issue #304 . Minor code change. No impact on any other code.
Test Plan
All tests pass. N