-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failures by adding apt-get update to Github Actions #3082
Conversation
Well looks like Travis is failing... will investigate tomorrow. Edit: this link should fix the issue, will test tomorrow. Expect some spam from this PR since I can't test this on embg/zstd (Travis CI doesn't give free credits for public repos anymore). (note to self: Travis debug instructions here) Edit: also used this link to fix Travis (there were multiple keys that had to be updated). |
b2d1a6a
to
9e0b2aa
Compare
Fixed most of the Travis issues, but there is one that apparently can only be fixed by moving away from Trusty. So there are two options:
Here is the failing Travis job: https://app.travis-ci.com/github/facebook/zstd/jobs/561969471 |
The failing Bottom line : we would be better off removing that test from Oh, and btw, it seems we already have such a test : Just check it's "equivalent enough" to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it.
Following advice from here and here, add
sudo apt-get update
to hopefully avoid this CI error:The first time I ran CI on this commit (on a PR in embg/zstd) I got a weird failure on a different job, but the second time everything passed. I propose we land this for now (if it passes CI on facebook/zstd), and if the issue persists there are some other things in the first link above that we can try.