Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable STATIC_BMI2 for gcc/clang #3080

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

TocarIP
Copy link
Contributor

@TocarIP TocarIP commented Mar 1, 2022

Some usage (e.g. BIT_getLowerBit) uses without checking for MSVC,
so enabling for clang gives a small performance boost.

@TocarIP TocarIP force-pushed the tokarip/static_bmi2 branch 4 times, most recently from 0746fc5 to 09bd289 Compare March 2, 2022 20:08
@embg
Copy link
Contributor

embg commented Mar 3, 2022

The CI failures are probably unrelated, and #3082 should fix them. If you re-run checks on this PR those jobs shouldn't fail again.

Some usage (e.g. BIT_getLowerBit) uses it without checking for MSVC,
so enabling for clang gives a small performance boost.
@TocarIP TocarIP force-pushed the tokarip/static_bmi2 branch from 09bd289 to 7c3d1cb Compare March 3, 2022 20:04
@Cyan4973 Cyan4973 merged commit e8448a3 into facebook:dev Mar 3, 2022
@Cyan4973 Cyan4973 mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants