Fix merge operand reappearing when covered by DeleteRange #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ajkr
force-pushed
the
range-del-fix-iter-prev-merge
branch
from
2de7913
to
585457a
Compare
|
@ajkr has updated the pull request. Re-import the pull request |
|
will leave it out of HISTORY.md since we don't think it was a problem before #4432, which is unreleased (though if we backport that we need to remember to backport this too). |
There was a problem hiding this comment.
ajkr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
petermattis
pushed a commit
to petermattis/rocksdb
that referenced
this pull request
Oct 17, 2018
) Summary: Even during `DBIter::Prev()`, there is a case where we need to use `RangeDelPositioningMode::kForwardTraversal`. In particular, when we hit too many internal keys for a single user key, we use seek to find the newest internal key. If it's a merge operand, we then scan forwards, collecting the merge operands. This forward scan should be using `RangeDelPositioningMode::kForwardTraversal`. Pull Request resolved: facebook#4481 Differential Revision: D10319507 Pulled By: ajkr fbshipit-source-id: b5ce7352461f3a7696b28a5136ae0076f2bde51f
41 tasks
petermattis
pushed a commit
to cockroachdb/rocksdb
that referenced
this pull request
Dec 5, 2018
) Summary: Even during `DBIter::Prev()`, there is a case where we need to use `RangeDelPositioningMode::kForwardTraversal`. In particular, when we hit too many internal keys for a single user key, we use seek to find the newest internal key. If it's a merge operand, we then scan forwards, collecting the merge operands. This forward scan should be using `RangeDelPositioningMode::kForwardTraversal`. Pull Request resolved: facebook#4481 Differential Revision: D10319507 Pulled By: ajkr fbshipit-source-id: b5ce7352461f3a7696b28a5136ae0076f2bde51f
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even during
DBIter::Prev(), there is a case where we need to useRangeDelPositioningMode::kForwardTraversal. In particular, when we hit too many internal keys for a single user key, we use seek to find the newest internal key. If it's a merge operand, we then scan forwards, collecting the merge operands. This forward scan should be usingRangeDelPositioningMode::kForwardTraversal.Test Plan: new test case