5.17 upgrade checklist

[benesch]

• b4db6b4 Remove unused variables that the compiler is complaining about
• 45fbaf2 Pass manual_wal_flush also to the first wal file
  Original upstream commit 718c1c9 is present.
• fb75bc2 Rename function for handling WAL write error
  Original upstream commit 4d51fea is present.
• a66ad5a check return status for Sync() and Append() calls to avoid corruption
  Original upstream commit e1e826b is present.
• [peter] ff5ecc3 Fix range tombstones written to more files than necessary (Fix range tombstones written to more files than necessary facebook/rocksdb#4592)
  Backported as 27ad7fe.
• a79dcf4 add kEntryRangeDeletion
  Original upstream commit 31ee4bf is present.
• [peter] 99a3aeb Fix merge operand reappearing when covered by DeleteRange (Fix merge operand reappearing when covered by DeleteRange facebook/rocksdb#4481)
  Backported as 13de2e5.
• [peter] 6a78d8a DeleteRange regression tests using public API (DeleteRange regression tests using public API facebook/rocksdb#4476)
  Backported as 88208f1.
• [peter] 6f11959 Extend PartialRangeTombstone to use InternalKeys
  Forward ported as 1e342df.
• [peter] a8370d4 Truncate range tombstones by leveraging InternalKeys (Truncate range tombstones by leveraging InternalKeys facebook/rocksdb#4432)
  Backported as f9dbc8a.
• 5bd0dca Fix a lint error due to unspecified move evaluation order (Fix a lint error due to unspecified move evaluation order facebook/rocksdb#4348)
  Original upstream commit ced618c is present.
• [peter] 7a67fd5 Support non-pinned keys/vals in RangeDelAggregator
  Original upstream commit ef7815b is present.
• d0104d9 Add some missing override keywords
  Unnecessary.
• 0721e1b Add SST ingestion to ldb (Add SST ingestion to ldb facebook/rocksdb#4205)
  Original upstream commit de7f423 is present.
• db45813 Unit test for custom comparator RangeDelAggregator (Unit test for custom comparator RangeDelAggregator facebook/rocksdb#4388)
  Original upstream commit 990b52e is present.
• 372d4ce Skip range deletions at seqno zero when collapsing (Skip range deletions at seqno zero when collapsing facebook/rocksdb#4216)
  Original upstream commit f8f6983 is present.
• 1cbf8b0 Reorder CollapsedRangeDelMap conditional to match upstream
  Unnecessary.
• 5d12dc2 Reformat range_del_aggregator.cc to match upstream style
  Unnecessary.
• 625f02c Handle tombstones at the same seqno in the CollapsedRangeDelMap
  Original upstream commit 17edc82 is present.
• [peter] d62a998 Fix a bug in iteration while skipping range deletion tombstones
  Forward ported as c967991.
• [peter] baf0248 Restrict RangeDelAggregator's tombstone end-key truncation
  Original upstream commit c86a22a is present.
• [peter] 55ffa77 Adjust wording of PartialRangeTombstone description
  Forward ported as 13c8e70.
• [peter] 12db3d2 Fix memory bug in CollapsedRangeDelMap::GetTombstone
  Forward ported as 43bec7e.
• [peter] 6b64b6f Fix skipping of range deleted keys in BlockBasedTableIterator
  Forward ported as ac96261.
• 1f02660 Fix GitHub issue rocksdb fails to compile in Fedora 28 / gcc version 8.0.1 facebook/rocksdb#3716: gcc-8 warnings
  Original upstream commit dee95a1 is present.
• [peter] 2a27159 Properly handle range tombstones at the same seqnum as a key
  Forward ported as d793039.
• [peter] e2be260 Stop-gap for unimplemented UncollapsedRangeDelMap::ShouldDeleteRange
  Forward ported as eb50d74.
• d6b0247 Relax VersionStorageInfo::GetOverlappingInputs check
  Original upstream commit 90fc406 is present.
• [peter] ce6b81d Truncate range tombstones from sstables
  Original upstream commit 90fc406 is present.
• [peter] 450e91a Removed the unused TableCache::NewRangeTombstoneIterator
  Original upstream commit 90fc406 is present.
• [peter] 1eeec9a Skip ranges of deleted keys in BlockBasedTableIterator
  Forward ported as e80b4e3.
• [peter] c147ea0 Add RangeDelAggregator::GetTombstone
  Forward ported as 2b588fe.
• [peter] e4db218 Skip L0 sstables which are covered by a range tombstone
  Forward ported as 2817952.
• [peter] 9460832 Skip sstables that are entirely covered by a range tombstone
  Forward ported as d88fd4b.
• 92b9e84 Range deletion performance improvements + cleanup (Range deletion performance improvements + cleanup facebook/rocksdb#4014)
  Original upstream commit 5f3088d is present.
• de88698 Add table property tracking number of range deletions (Add table property tracking number of range deletions facebook/rocksdb#4016)
  Original upstream commit 17339dc is present.
• 8758409 Recommit "Avoid adding tombstones of the same file to RangeDelAggregator multiple times"
  Original upstream commit 72942ad is present.
• edd4b23 Test range deletions with more configurations
  Original upstream commit 5cd8240 is present.
• 8865dc6 Fix race condition via concurrent FlushWAL
  Original upstream commit 35a4469 is present.
• 7ca2e5b Check conflict at output level in CompactFiles
  Original upstream commit 4420df4 is present.
• c3a10db util/crc32c: always compile FastCRC32 with SSE4.2 instructions
  Forward ported as af810f1.

[petermattis]

Current status is running into problems forward porting 1eeec9a. Patches have been tweaked, but there are test failures. Will continue tomorrow or Friday.