Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group rocksdb.sst.read.micros stat by IOActivity flush and compaction #11288

Closed
wants to merge 17 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add explicit to some single-parameter constructor
hx235 committed Apr 20, 2023
commit e3c982338c939650e6066227f88427257ba5df57
2 changes: 1 addition & 1 deletion db/version_edit_handler.h
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@ class VersionEditHandlerBase {

class ListColumnFamiliesHandler : public VersionEditHandlerBase {
public:
ListColumnFamiliesHandler(const ReadOptions& read_options)
explicit ListColumnFamiliesHandler(const ReadOptions& read_options)
: VersionEditHandlerBase(read_options) {}

~ListColumnFamiliesHandler() override {}
2 changes: 1 addition & 1 deletion include/rocksdb/options.h
Original file line number Diff line number Diff line change
@@ -1700,7 +1700,7 @@ struct ReadOptions {

ReadOptions();
ReadOptions(bool cksum, bool cache);
ReadOptions(Env::IOActivity io_activity);
explicit ReadOptions(Env::IOActivity io_activity);
};

// Options that control write operations
2 changes: 1 addition & 1 deletion test_util/thread_io_activity.h
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ extern Env::IOActivity TEST_GetThreadIOActivity();

class ThreadIOActivityGuardForTest {
public:
ThreadIOActivityGuardForTest(Env::IOActivity io_activity);
explicit ThreadIOActivityGuardForTest(Env::IOActivity io_activity);

~ThreadIOActivityGuardForTest();
};