Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to 15.6.0 changelog #9951

Merged
merged 3 commits into from
Jun 13, 2017
Merged

Minor fixes to 15.6.0 changelog #9951

merged 3 commits into from
Jun 13, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jun 13, 2017

  • Move unreleased changes to addons back into the collapsed section
  • Move React DOM changes to React DOM section
  • Replace apostrophes with backticks where necessary, use the same verb tense everywhere
  • Rephrase some changes to be more descriptive

@gaearon gaearon requested a review from flarnie June 13, 2017 19:56
@gaearon
Copy link
Collaborator Author

gaearon commented Jun 13, 2017

After merge, we'll need to cherry-pick back to the dev and stable branches, and also update the GH Release notes.

@gaearon gaearon mentioned this pull request Jun 13, 2017
Merged
@flarnie
Copy link
Contributor

flarnie commented Jun 13, 2017

Thanks @gaearon - as we discussed, I'll merge this and do the follow-up to update the dev/stable branches and the GH release notes.

@flarnie flarnie merged commit 00340f4 into master Jun 13, 2017
flarnie added a commit to flarnie/react that referenced this pull request Jun 13, 2017
@flarnie
Improvements to blog post, and add self to authors.yml
ae22bc5 
**what is the change?:**
- Add self to contributors so my name turns into a link
- Use backticks for code-ish things
- Second header to ##, not #
- Change production mode link to the new address per @bvaughn's comment
- Update changelog with fixes from facebook#9951

**why make this change?:**
Make things more clear and accurate.

**test plan:**
Visual inspect - @flarnie will paste an image of how it appears in the
actual docs.

**issue:**
facebook#9398
@gaearon gaearon deleted the gaearon-patch-7 branch June 13, 2017 21:50
flarnie pushed a commit that referenced this pull request Jun 13, 2017
@gaearon @flarnie
Minor fixes to 15.6.0 changelog (#9951)
8af5d23 
* Minor fixes to 15.6.0 changelog

* Remove remaining double space

* Backticks
flarnie pushed a commit that referenced this pull request Jun 13, 2017
@gaearon @flarnie
Minor fixes to 15.6.0 changelog (#9951)
0652bb4 
* Minor fixes to 15.6.0 changelog

* Remove remaining double space

* Backticks
flarnie pushed a commit that referenced this pull request Jun 13, 2017
@gaearon @flarnie
Minor fixes to 15.6.0 changelog (#9951)
16d7773 
* Minor fixes to 15.6.0 changelog

* Remove remaining double space

* Backticks
flarnie added a commit that referenced this pull request Jun 13, 2017
@flarnie
Blog post for 15.6.0 (#9950)
ce6108d 
* Blog post for 15.6.0

**what is the change?:**
A short and sweet summary of 15.6.0 changes

**why make this change?:**
To thank community contributors and call out important changes.

**test plan:**
Visual inspection.
I also looked it over in a markdown viewer - http://dillinger.io/

**issue:**
#9398

* Add 'Installation' and 'Changelog' to 15.6.0 blog post

**what is the change?:**
Added the 'Installation' section we have on most release blog posts,
customized for the 15.6.0 version of React.
Added the 'Changelog' from master to the blog post.

**why make this change?:**
To show folks how to install React and what changes are in this release.

**test plan:**
Visual inspection

**issue:**
#9398

* Improvements to blog post, and add self to `authors.yml`

**what is the change?:**
- Add self to contributors so my name turns into a link
- Use backticks for code-ish things
- Second header to ##, not #
- Change production mode link to the new address per @bvaughn's comment
- Update changelog with fixes from #9951

**why make this change?:**
Make things more clear and accurate.

**test plan:**
Visual inspect - @flarnie will paste an image of how it appears in the
actual docs.

**issue:**
#9398

* Further improvements to 15.6 blog post

**what is the change?:**
- Reword heading about deprecation warning changes
- add 'br' s to the list of installation options
- add some stray missing backticks

**why make this change?:**
Clarity and readability

**test plan:**
Visual inspection

**issue:**
#9398
flarnie added a commit that referenced this pull request Jun 13, 2017
@flarnie
Blog post for 15.6.0 (#9950)
c1fe254 
* Blog post for 15.6.0

**what is the change?:**
A short and sweet summary of 15.6.0 changes

**why make this change?:**
To thank community contributors and call out important changes.

**test plan:**
Visual inspection.
I also looked it over in a markdown viewer - http://dillinger.io/

**issue:**
#9398

* Add 'Installation' and 'Changelog' to 15.6.0 blog post

**what is the change?:**
Added the 'Installation' section we have on most release blog posts,
customized for the 15.6.0 version of React.
Added the 'Changelog' from master to the blog post.

**why make this change?:**
To show folks how to install React and what changes are in this release.

**test plan:**
Visual inspection

**issue:**
#9398

* Improvements to blog post, and add self to `authors.yml`

**what is the change?:**
- Add self to contributors so my name turns into a link
- Use backticks for code-ish things
- Second header to ##, not #
- Change production mode link to the new address per @bvaughn's comment
- Update changelog with fixes from #9951

**why make this change?:**
Make things more clear and accurate.

**test plan:**
Visual inspect - @flarnie will paste an image of how it appears in the
actual docs.

**issue:**
#9398

* Further improvements to 15.6 blog post

**what is the change?:**
- Reword heading about deprecation warning changes
- add 'br' s to the list of installation options
- add some stray missing backticks

**why make this change?:**
Clarity and readability

**test plan:**
Visual inspection

**issue:**
#9398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flarnie flarnie flarnie approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @flarnie @facebook-github-bot