[#9627] Fix create-react-class isMounted ordering issue #9638
+32
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the IsMountedMixin in two so that the __isMounted flag is set to false after componentWillUnmount is executed in mixins and the component.
The sad part is there's no automated way to do it. 😞 I can do it again, but I'd like to make sure we did all changes we want to first. |
|
Looks great. Flow failure seems unrelated—if it continues after merge I'll investigate. Thanks! |
|
(I confirmed the test replicates 15.4.x behavior) |
nhunzaker
pushed a commit
to nhunzaker/react
that referenced
this pull request
Jun 13, 2017
…book#9638) * [facebook#9627] Fix create-react-class isMounted ordering issue Split the IsMountedMixin in two so that the __isMounted flag is set to false after componentWillUnmount is executed in mixins and the component. * Revert changes to integration test
This was referenced Aug 26, 2019
This was referenced Sep 22, 2019
This was referenced Jan 23, 2020
This was referenced Feb 23, 2020
This was referenced Mar 18, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the IsMountedMixin in two so that the __isMounted flag is set to false after componentWillUnmount is executed in mixins and the component.
Fixes #9627
@acdlite I wasn't sure how to build the create-react-class.js and create-react-class.min.js.
yarn builddid not seem to touch those files.