[Fizz][Legacy] use static markup mode for renderToStaticNodeStream #28606

gnoff · 2024-03-21T15:28:02Z

Since it was first implemented renderToStaticNodeStream never correctly set the renderer state to mark the output as static markup which means it was functionally the same as renderToNodeStream. This change fixes this oversight. While we are removing renderToNodeStream in a future version we never did deprecate the static version of this API because it has no immediate analog in the modern APIs.

gnoff · 2024-03-21T15:28:30Z

packages/react-dom/src/__tests__/ReactServerRendering-test.js

@@ -609,6 +609,41 @@ describe('ReactDOMServer', () => {
        expect(response.read()).toBeNull();
      });
    });
+
+    it('should refer users to new apis when using suspense', async () => {


this test already existed it was just in the wrong describe block. It now correctly lives in the renderToNodeStream block

gnoff · 2024-03-21T15:29:13Z

packages/react-dom/src/__tests__/ReactServerRendering-test.js

@@ -632,7 +667,7 @@ describe('ReactDOMServer', () => {
      });
    });

-    it('should refer users to new apis when using suspense', async () => {
+    it('should omit text and suspense placeholders', async () => {


This test is now asserting the removal of hydration markup even though I kept the test form largely intact

react-sizebot · 2024-03-21T15:33:24Z

Comparing: 9c75cd5...ca63dc8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.83 kB	176.83 kB	=	54.91 kB	54.90 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.26 kB	173.26 kB	=	54.04 kB	54.04 kB
facebook-www/ReactDOM-prod.classic.js	=	594.27 kB	594.27 kB	=	104.44 kB	104.44 kB
facebook-www/ReactDOM-prod.modern.js	=	577.53 kB	577.53 kB	=	101.47 kB	101.47 kB
test_utils/ReactAllWarnings.js	Deleted	66.63 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.63 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Generated by 🚫 dangerJS against ca63dc8

Stacked on #28606 renderToNodeStream has been deprecated since React 18 with a warning indicating users should upgrade to renderToPipeableStream. This change removes renderToNodeStream

Stacked on #28606 renderToNodeStream has been deprecated since React 18 with a warning indicating users should upgrade to renderToPipeableStream. This change removes renderToNodeStream DiffTrain build for [8436bcc](8436bcc)

…acebook#28606) Since it was first implemented renderToStaticNodeStream never correctly set the renderer state to mark the output as static markup which means it was functionally the same as renderToNodeStream. This change fixes this oversight. While we are removing renderToNodeStream in a future version we never did deprecate the static version of this API because it has no immediate analog in the modern APIs.

Stacked on facebook#28606 renderToNodeStream has been deprecated since React 18 with a warning indicating users should upgrade to renderToPipeableStream. This change removes renderToNodeStream

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 21, 2024

gnoff commented Mar 21, 2024

View reviewed changes

gnoff requested a review from sebmarkbage March 21, 2024 15:29

gnoff mentioned this pull request Mar 21, 2024

[Fizz][Legacy] Remove renderToNodeStream #28607

Merged

sebmarkbage approved these changes Mar 21, 2024

View reviewed changes

gnoff merged commit c47fee5 into facebook:main Mar 21, 2024
38 checks passed

gnoff deleted the fix-static-node-stream branch March 21, 2024 18:03

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Closed

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fizz][Legacy] use static markup mode for renderToStaticNodeStream #28606

[Fizz][Legacy] use static markup mode for renderToStaticNodeStream #28606

gnoff commented Mar 21, 2024

gnoff Mar 21, 2024

gnoff Mar 21, 2024

react-sizebot commented Mar 21, 2024

[Fizz][Legacy] use static markup mode for renderToStaticNodeStream #28606

[Fizz][Legacy] use static markup mode for renderToStaticNodeStream #28606

Conversation

gnoff commented Mar 21, 2024

gnoff Mar 21, 2024

Choose a reason for hiding this comment

gnoff Mar 21, 2024

Choose a reason for hiding this comment

react-sizebot commented Mar 21, 2024

Critical size changes

Significant size changes