Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rendering BigInt #24580

Merged
merged 11 commits into from
Feb 26, 2024
Merged

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented May 18, 2022

Summary

Closes #20492

Adds support for rendering BigInt behind enableBigIntSupport (experimental only). This includes support for values of input, option and textarea as BigInt for consistency. Otherwise <div>{5n}</div> would work but not <option>{5n}</option>.

BigInt values are now rendered instead of being treated like no value was given. For example, <div>{5n}</div> would previously render <div></div>. Now it renders the stringified value of the BigInt i.e. <div>5</div>.

The only negative impact I can imagine is the same mistake make people for numbers like <div>{length && items.map(...)}</div> which results in the infamous "0" display in your UI. With BigInt you didn't have this but now you have. But then I'm not aware of any built-in that uses BigInt for collection size.

How did you test this change?

@sizebot
Copy link

sizebot commented May 18, 2022

Comparing: 4cd788a...a87598f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.08% 131.79 kB 131.89 kB +0.09% 42.40 kB 42.44 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.08% 137.06 kB 137.16 kB +0.10% 44.00 kB 44.04 kB
facebook-www/ReactDOM-prod.classic.js +0.05% 457.17 kB 457.39 kB +0.04% 83.22 kB 83.25 kB
facebook-www/ReactDOM-prod.modern.js +0.05% 442.41 kB 442.63 kB +0.03% 80.94 kB 80.96 kB
facebook-www/ReactDOMForked-prod.classic.js +0.05% 457.94 kB 458.16 kB +0.03% 83.33 kB 83.36 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServer-prod.classic.js +0.31% 48.03 kB 48.18 kB +0.24% 11.21 kB 11.24 kB
facebook-www/ReactDOMServer-dev.classic.js +0.29% 157.79 kB 158.24 kB +0.37% 39.99 kB 40.13 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.24% 12.35 kB 12.38 kB +0.14% 3.68 kB 3.69 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.24% 12.35 kB 12.38 kB +0.14% 3.68 kB 3.69 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.24% 12.35 kB 12.38 kB +0.14% 3.68 kB 3.69 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.24% 12.42 kB 12.45 kB +0.14% 3.70 kB 3.70 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.24% 12.42 kB 12.45 kB +0.14% 3.70 kB 3.70 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.24% 12.42 kB 12.45 kB +0.14% 3.70 kB 3.70 kB
oss-experimental/react/cjs/react.shared-subset.production.min.js +0.22% 6.40 kB 6.42 kB +0.27% 2.62 kB 2.62 kB
oss-stable-semver/react-server/cjs/react-server.development.js +0.22% 130.50 kB 130.78 kB +0.29% 32.67 kB 32.77 kB
oss-stable/react-server/cjs/react-server.development.js +0.22% 130.50 kB 130.78 kB +0.29% 32.67 kB 32.77 kB
oss-experimental/react-server/cjs/react-server.development.js +0.21% 131.37 kB 131.65 kB +0.29% 32.88 kB 32.97 kB
oss-stable-semver/react/cjs/react.production.min.js +0.20% 6.91 kB 6.93 kB +0.30% 2.70 kB 2.70 kB
oss-stable/react/cjs/react.production.min.js +0.20% 6.94 kB 6.95 kB +0.33% 2.72 kB 2.73 kB

Generated by 🚫 dangerJS against a87598f

@eps1lon eps1lon force-pushed the feat/bigint/render branch 2 times, most recently from e099a7b to 7b4ffc7 Compare May 18, 2022 20:09
@eps1lon eps1lon marked this pull request as ready for review May 18, 2022 20:15
@gaearon
Copy link
Collaborator

gaearon commented May 18, 2022

If we support this, should we also support them as keys? What are the arguments for and against? What about attribute values? Does it already work there?

@eps1lon
Copy link
Collaborator Author

eps1lon commented May 19, 2022

What about attribute values? Does it already work there?

It works for attributes that don't get any special treatments (tested with data-test). But from looking through all the typeof val === 'number' occurences in the codebase, it probably doesn't work for <input value /> or <option value />. I left this as a TODO in the PR description.

If we support this, should we also support them as keys? What are the arguments for and against?

I'd probably just support BigInt for key for consistency with children and other attributes. An argument against it would be that bigints as keys allows lists with a huge number of items though that argument isn't all that convincing since lists with Number.MAX_SAFE_INTEGER items are probably already too big.
An argument for BigInt as key would be if you have items whos ID is a BigInt

I find the following two argument against bigint support the most convincing:

  • implementation work (now and future): almost every typeof value === 'number' check needs to consider 'bigint' whereas it's fairly trivial to just do String(someBigInt) in your codebase
  • unclear how this works with React Server Components (you can't JSON.stringify BigInt so you need to special case (de-)serialization

@eps1lon eps1lon force-pushed the feat/bigint/render branch 2 times, most recently from 071e078 to 31bb294 Compare July 2, 2022 07:48
@@ -74,6 +74,12 @@ describe('ReactDOMServerIntegration', () => {
expect(e.nodeValue).toMatch('42');
});

itRenders('a biging', async render => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
itRenders('a biging', async render => {
itRenders('a bigint', async render => {

👀

Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be flagged or landed as part of next major.

@react-sizebot
Copy link

react-sizebot commented Feb 17, 2024

Comparing: 239d06e...ad6e64f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.01% 176.86 kB 176.89 kB +0.02% 55.13 kB 55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.11% 179.01 kB 179.20 kB +0.07% 55.77 kB 55.81 kB
facebook-www/ReactDOM-prod.classic.js = 594.00 kB 594.04 kB = 104.93 kB 104.94 kB
facebook-www/ReactDOM-prod.modern.js = 577.29 kB 577.33 kB = 101.95 kB 101.96 kB
test_utils/ReactAllWarnings.js Deleted 66.35 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.33% 15.37 kB 15.42 kB +0.19% 4.68 kB 4.69 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.33% 15.37 kB 15.42 kB +0.19% 4.68 kB 4.69 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.33% 15.37 kB 15.42 kB +0.19% 4.68 kB 4.69 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.33% 15.45 kB 15.50 kB +0.19% 4.69 kB 4.70 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.33% 15.45 kB 15.50 kB +0.19% 4.69 kB 4.70 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.33% 15.45 kB 15.50 kB +0.19% 4.69 kB 4.70 kB
oss-stable-semver/react/cjs/react.react-server.production.js +0.32% 33.45 kB 33.56 kB +0.37% 9.96 kB 9.99 kB
oss-stable/react/cjs/react.react-server.production.js +0.32% 33.47 kB 33.58 kB +0.34% 9.99 kB 10.02 kB
oss-stable-semver/react/cjs/react.production.js +0.28% 38.29 kB 38.40 kB +0.34% 10.67 kB 10.71 kB
oss-stable/react/cjs/react.production.js +0.28% 38.32 kB 38.43 kB +0.31% 10.70 kB 10.74 kB
test_utils/ReactAllWarnings.js Deleted 66.35 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against ad6e64f

@eps1lon eps1lon changed the title Add support for rendering BigInt as children Add support for rendering BigInt Feb 18, 2024
@eps1lon eps1lon force-pushed the feat/bigint/render branch 3 times, most recently from 6efee0c to 822d3e4 Compare February 18, 2024 21:44
@eps1lon
Copy link
Collaborator Author

eps1lon commented Feb 18, 2024

If we support this, should we also support them as keys? What are the arguments for and against?

We already support it in keys since we just stringify keys. The only requirement for keys is that they stringify to something unique within a collection.

Needs to be flagged or landed as part of next major.

Added a flag. I don't think this constitutes a breaking change so I wouldn't block 19 on it and defer it to a minor if we need more time to test it.

@eps1lon eps1lon merged commit 2f240c9 into facebook:main Feb 26, 2024
37 checks passed
@eps1lon eps1lon deleted the feat/bigint/render branch February 26, 2024 18:18
github-actions bot pushed a commit that referenced this pull request Feb 26, 2024
hoxyq added a commit that referenced this pull request Mar 5, 2024
* feat[devtools]: symbolicate source for inspected element
([hoxyq](https://github.com/hoxyq) in
[#28471](#28471))
* refactor[devtools]: lazily define source for fiber based on component
stacks ([hoxyq](https://github.com/hoxyq) in
[#28351](#28351))
* fix[devtools/tree/element]: onClick -> onMouseDown to handle first
click correctly ([hoxyq](https://github.com/hoxyq) in
[#28486](#28486))
* [DOM] disable legacy mode behind flag
([gnoff](https://github.com/gnoff) in
[#28468](#28468))
* Fix Broken Links In Documentation
([justindhillon](https://github.com/justindhillon) in
[#28321](#28321))
* Update /link URLs to react.dev
([rickhanlonii](https://github.com/rickhanlonii) in
[#28477](#28477))
* [tests] add support for @GATE pragma
([gnoff](https://github.com/gnoff) in
[#28479](#28479))
* Devtools: Unwrap Promise in useFormState
([eps1lon](https://github.com/eps1lon) in
[#28319](#28319))
* Add support for rendering BigInt
([eps1lon](https://github.com/eps1lon) in
[#24580](#24580))
* Include server component names in the componentStack in DEV
([sebmarkbage](https://github.com/sebmarkbage) in
[#28415](#28415))
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
gnoff added a commit to gnoff/next.js that referenced this pull request Mar 25, 2024
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
* feat[devtools]: symbolicate source for inspected element
([hoxyq](https://github.com/hoxyq) in
[facebook#28471](facebook#28471))
* refactor[devtools]: lazily define source for fiber based on component
stacks ([hoxyq](https://github.com/hoxyq) in
[facebook#28351](facebook#28351))
* fix[devtools/tree/element]: onClick -> onMouseDown to handle first
click correctly ([hoxyq](https://github.com/hoxyq) in
[facebook#28486](facebook#28486))
* [DOM] disable legacy mode behind flag
([gnoff](https://github.com/gnoff) in
[facebook#28468](facebook#28468))
* Fix Broken Links In Documentation
([justindhillon](https://github.com/justindhillon) in
[facebook#28321](facebook#28321))
* Update /link URLs to react.dev
([rickhanlonii](https://github.com/rickhanlonii) in
[facebook#28477](facebook#28477))
* [tests] add support for @GATE pragma
([gnoff](https://github.com/gnoff) in
[facebook#28479](facebook#28479))
* Devtools: Unwrap Promise in useFormState
([eps1lon](https://github.com/eps1lon) in
[facebook#28319](facebook#28319))
* Add support for rendering BigInt
([eps1lon](https://github.com/eps1lon) in
[facebook#24580](facebook#24580))
* Include server component names in the componentStack in DEV
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#28415](facebook#28415))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
eps1lon added a commit to vercel/next.js that referenced this pull request Apr 19, 2024
### React upstream changes

- facebook/react#28643
- facebook/react#28628
- facebook/react#28361
- facebook/react#28513
- facebook/react#28299
- facebook/react#28617
- facebook/react#28618
- facebook/react#28621
- facebook/react#28614
- facebook/react#28596
- facebook/react#28625
- facebook/react#28616
- facebook/react#28491
- facebook/react#28583
- facebook/react#28427
- facebook/react#28613
- facebook/react#28599
- facebook/react#28611
- facebook/react#28610
- facebook/react#28606
- facebook/react#28598
- facebook/react#28549
- facebook/react#28557
- facebook/react#28467
- facebook/react#28591
- facebook/react#28459
- facebook/react#28590
- facebook/react#28564
- facebook/react#28582
- facebook/react#28579
- facebook/react#28578
- facebook/react#28521
- facebook/react#28550
- facebook/react#28576
- facebook/react#28577
- facebook/react#28571
- facebook/react#28572
- facebook/react#28560
- facebook/react#28569
- facebook/react#28573
- facebook/react#28546
- facebook/react#28568
- facebook/react#28562
- facebook/react#28566
- facebook/react#28565
- facebook/react#28559
- facebook/react#28508
- facebook/react#20432
- facebook/react#28555
- facebook/react#24730
- facebook/react#28472
- facebook/react#27991
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
- facebook/react#28514
- facebook/react#28548
- facebook/react#28526
- facebook/react#28515
- facebook/react#28533
- facebook/react#28532
- facebook/react#28531
- facebook/react#28407
- facebook/react#28522
- facebook/react#28538
- facebook/react#28509
- facebook/react#28534
- facebook/react#28527
- facebook/react#28528
- facebook/react#28519
- facebook/react#28411
- facebook/react#28520
- facebook/react#28518
- facebook/react#28493
- facebook/react#28504
- facebook/react#28499
- facebook/react#28501
- facebook/react#28496
- facebook/react#28471
- facebook/react#28351
- facebook/react#28486
- facebook/react#28490
- facebook/react#28488
- facebook/react#28468
- facebook/react#28321
- facebook/react#28477
- facebook/react#28479
- facebook/react#28480
- facebook/react#28478
- facebook/react#28464
- facebook/react#28475
- facebook/react#28456
- facebook/react#28319
- facebook/react#28345
- facebook/react#28337
- facebook/react#28335
- facebook/react#28466
- facebook/react#28462
- facebook/react#28322
- facebook/react#28444
- facebook/react#28448
- facebook/react#28449
- facebook/react#28446
- facebook/react#28447
- facebook/react#24580
@sant123
Copy link

sant123 commented Jun 25, 2024

This does not work on 18.3.1 😕

@eps1lon
Copy link
Collaborator Author

eps1lon commented Jun 25, 2024

It wasn't intended for 18.x. It's part of React 19

@sant123
Copy link

sant123 commented Jun 25, 2024

Ohhh got it, thanks!!

@bernaferrari
Copy link

bernaferrari commented Sep 17, 2024

I really hate this change. React.Children.toArray(children) won't work anymore because Type 'bigint' is not assignable to type 'ReactNode | ReactNode[].

This breaks: (Spread types may only be created from object types.ts(2698))

   {React.Children.map(children, (child) => {
          if (!React.isValidElement(child)) {
            return null
          }

          return React.cloneElement(child, {
            ...child.props,
            variant: child.props?.variant || variant,
          })
        })}

Also createPortal won't work anymore: vercel/next.js#64753

And finally, you need to wrap some things with <>{children}</> instead of using {children}.

@eps1lon
Copy link
Collaborator Author

eps1lon commented Sep 17, 2024

And finally, you need to wrap some things with <>{children}</> instead of using {children}.

You shouldn't have to. What makes you say that?

@bernaferrari
Copy link

If you check the discussion there is more people with the same problem: vercel/next.js#64753

Not sure it is shadcn/ui, nextjs or what.

@eps1lon
Copy link
Collaborator Author

eps1lon commented Sep 17, 2024

Then let's identify the issue first before concluding this is a bad change. I'll check out the repro. But let's confirm things first before opening up multiple issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: BigInt does not get toString()'d when rendered
9 participants