Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete processStringChunk #26896

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Delete processStringChunk #26896

merged 1 commit into from
Jun 10, 2023

Conversation

sebmarkbage
Copy link
Collaborator

Follow up to #26827.

These can't include binary data and we don't really have any use cases that really require these to already be strings.

When the stream is encoded inside another protocol - such as HTML we need a different format that encode binary offsets and binary data.

@sebmarkbage
Delete processStringChunk
18ff594 
These can't include binary data and we don't really have any use cases that
really require these to already be strings.

When the stream is encoded inside another protocol - such as HTML we need a
different format that encode binary offsets and binary data.
@sebmarkbage sebmarkbage requested a review from gaearon June 3, 2023 23:46
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 3, 2023
@react-sizebot
Copy link

Comparing: e6fae30...18ff594

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.23 kB 164.23 kB = 51.73 kB 51.73 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.67 kB 171.67 kB = 53.97 kB 53.97 kB
facebook-www/ReactDOM-prod.classic.js = 570.12 kB 570.12 kB = 100.58 kB 100.58 kB
facebook-www/ReactDOM-prod.modern.js = 553.90 kB 553.90 kB = 97.75 kB 97.75 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-experimental/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB
oss-stable/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js = 10.45 kB 10.43 kB = 4.11 kB 4.11 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js = 10.45 kB 10.43 kB = 4.11 kB 4.11 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js = 10.45 kB 10.43 kB = 4.11 kB 4.11 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js = 10.19 kB 10.17 kB = 4.01 kB 4.01 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js = 10.19 kB 10.17 kB = 4.01 kB 4.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js = 10.19 kB 10.17 kB = 4.01 kB 4.01 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js = 10.17 kB 10.15 kB = 4.04 kB 4.04 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js = 10.17 kB 10.15 kB = 4.04 kB 4.04 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js = 10.17 kB 10.15 kB = 4.04 kB 4.04 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js = 9.51 kB 9.49 kB = 3.72 kB 3.72 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js = 9.51 kB 9.49 kB = 3.72 kB 3.72 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js = 9.51 kB 9.49 kB = 3.72 kB 3.72 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 49.14 kB 48.58 kB = 12.25 kB 12.17 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 49.14 kB 48.58 kB = 12.25 kB 12.17 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 49.14 kB 48.58 kB = 12.25 kB 12.17 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 47.60 kB 47.05 kB = 11.80 kB 11.72 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 47.60 kB 47.05 kB = 11.80 kB 11.72 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 47.60 kB 47.05 kB = 11.80 kB 11.72 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 46.70 kB 46.15 kB = 11.58 kB 11.50 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 46.70 kB 46.15 kB = 11.58 kB 11.50 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 46.70 kB 46.15 kB = 11.58 kB 11.50 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 44.16 kB 43.47 kB = 11.16 kB 11.03 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js = 44.16 kB 43.47 kB = 11.16 kB 11.03 kB
oss-stable/react-client/cjs/react-client-flight.development.js = 44.16 kB 43.47 kB = 11.16 kB 11.03 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js = 10.09 kB 9.90 kB = 4.00 kB 3.97 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js = 10.09 kB 9.90 kB = 4.00 kB 3.97 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js = 10.09 kB 9.90 kB = 4.00 kB 3.97 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js = 9.71 kB 9.52 kB = 3.81 kB 3.78 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js = 9.71 kB 9.52 kB = 3.81 kB 3.78 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js = 9.71 kB 9.52 kB = 3.81 kB 3.78 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-experimental/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB
oss-stable/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB

Generated by 🚫 dangerJS against 18ff594

@sebmarkbage sebmarkbage merged commit ce6842d into facebook:main Jun 10, 2023
@styfle styfle mentioned this pull request Jun 30, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Jul 4, 2023
@styfle @shuding
chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 (#52005)
9e4b87d 
This PR updates the vendored react dependencies using `pnpm sync-react`

### React upstream changes

- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

### Related

Closes #49409 (by facebook/react#26977)
fix NEXT-1189

Co-authored-by: Shu Ding <[email protected]>
@styfle styfle mentioned this pull request Jul 5, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Jul 6, 2023
@styfle @huozhi
chore(deps): bump react to 7118f5dd7 (#52282)
6dafc42 
Fixes #49409

### React upstream changes

- facebook/react#27045
- facebook/react#27051
- facebook/react#27032
- facebook/react#27031
- facebook/react#27029
- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

---------

Co-authored-by: Jiachi Liu <[email protected]>
shuding added a commit to vercel/next.js that referenced this pull request Jul 8, 2023
@styfle @shuding
chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 (#52005)
1ae3f42 
This PR updates the vendored react dependencies using `pnpm sync-react`

### React upstream changes

- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

### Related

Closes #49409 (by facebook/react#26977)
fix NEXT-1189

Co-authored-by: Shu Ding <[email protected]>
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@sebmarkbage @AndyPengc12
Delete processStringChunk (facebook#26896)
2cc4128 
Follow up to facebook#26827.

These can't include binary data and we don't really have any use cases
that really require these to already be strings.

When the stream is encoded inside another protocol - such as HTML we
need a different format that encode binary offsets and binary data.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@sebmarkbage
Delete processStringChunk (#26896)
42d25ac 
Follow up to #26827.

These can't include binary data and we don't really have any use cases
that really require these to already be strings.

When the stream is encoded inside another protocol - such as HTML we
need a different format that encode binary offsets and binary data.

DiffTrain build for commit ce6842d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @kassens @facebook-github-bot