Clean up enableSyncDefaultUpdates flag a bit #26858

rickhanlonii · 2023-05-26T02:01:44Z

Overview

Does a few things:

Renames enableSyncDefaultUpdates to forceConcurrentByDefaultForTesting
Changes the way it's used so it's dead-code eliminated separate from allowConcurrentByDefault
Deletes a bunch of the gated code

The gates that are deleted are unnecessary now. We were keeping them when we originally thought we would come back to being concurrent by default. But we've shifted and now sync-by default is the desired behavior long term, so there's no need to keep all these forked tests around.

I'll follow up to delete more of the forked behavior if possible. Ideally we wouldn't need this flag even if we're still using allowConcurrentByDefault.

rickhanlonii · 2023-05-26T02:02:18Z

packages/react-reconciler/src/ReactFiber.js

@@ -460,10 +460,13 @@ export function createHostRootFiber(
    }
    if (
      // We only use this flag for our repo tests to check both behaviors.
-      // TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
-      !enableSyncDefaultUpdates ||


I don't know why i wrote this clowny ass code this way before

rickhanlonii · 2023-05-26T02:03:14Z

packages/react-reconciler/src/__tests__/ReactExpiration-test.js

@@ -320,13 +313,10 @@ describe('ReactExpiration', () => {
    }

    // Initial mount
-    if (gate(flags => flags.enableSyncDefaultUpdates)) {


Most of these gate checks just switch to use transitions if we're sync by default. But we can just always use transitions, since that what we'll need to do long term to do these tests anyway.

react-sizebot · 2023-05-26T02:06:27Z

Comparing: 0210f0b...aa86e10

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	164.23 kB	164.23 kB	=	51.77 kB	51.77 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	171.59 kB	171.59 kB	=	53.98 kB	53.98 kB
facebook-www/ReactDOM-prod.classic.js	=	570.42 kB	570.42 kB	=	100.64 kB	100.64 kB
facebook-www/ReactDOM-prod.modern.js	=	554.16 kB	554.16 kB	=	97.82 kB	97.82 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against aa86e10

packages/react-reconciler/src/ReactFiber.js

## Overview Does a few things: - Renames `enableSyncDefaultUpdates` to `forceConcurrentByDefaultForTesting` - Changes the way it's used so it's dead-code eliminated separate from `allowConcurrentByDefault` - Deletes a bunch of the gated code The gates that are deleted are unnecessary now. We were keeping them when we originally thought we would come back to being concurrent by default. But we've shifted and now sync-by default is the desired behavior long term, so there's no need to keep all these forked tests around. I'll follow up to delete more of the forked behavior if possible. Ideally we wouldn't need this flag even if we're still using `allowConcurrentByDefault`. DiffTrain build for [018c58c](018c58c)

## Overview Does a few things: - Renames `enableSyncDefaultUpdates` to `forceConcurrentByDefaultForTesting` - Changes the way it's used so it's dead-code eliminated separate from `allowConcurrentByDefault` - Deletes a bunch of the gated code The gates that are deleted are unnecessary now. We were keeping them when we originally thought we would come back to being concurrent by default. But we've shifted and now sync-by default is the desired behavior long term, so there's no need to keep all these forked tests around. I'll follow up to delete more of the forked behavior if possible. Ideally we wouldn't need this flag even if we're still using `allowConcurrentByDefault`.

## Overview Does a few things: - Renames `enableSyncDefaultUpdates` to `forceConcurrentByDefaultForTesting` - Changes the way it's used so it's dead-code eliminated separate from `allowConcurrentByDefault` - Deletes a bunch of the gated code The gates that are deleted are unnecessary now. We were keeping them when we originally thought we would come back to being concurrent by default. But we've shifted and now sync-by default is the desired behavior long term, so there's no need to keep all these forked tests around. I'll follow up to delete more of the forked behavior if possible. Ideally we wouldn't need this flag even if we're still using `allowConcurrentByDefault`. DiffTrain build for commit 018c58c.

Clean up enableSyncDefaultUpdates flag a bit

8786805

rickhanlonii requested review from kassens, acdlite and tyao1 May 26, 2023 02:01

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 26, 2023

rickhanlonii commented May 26, 2023

View reviewed changes

tyao1 reviewed May 26, 2023

View reviewed changes

packages/react-reconciler/src/ReactFiber.js Outdated Show resolved Hide resolved

rickhanlonii added 4 commits May 31, 2023 09:34

Flip bool

9f02826

Fix tests

0e8dd54

Fix tests

f708808

Fix tests

aa86e10

rickhanlonii force-pushed the rh/sync-flag-updates branch from d3bc7a2 to aa86e10 Compare May 31, 2023 15:02

rickhanlonii requested a review from tyao1 May 31, 2023 19:50

tyao1 approved these changes May 31, 2023

View reviewed changes

rickhanlonii merged commit 018c58c into facebook:main Jun 1, 2023

rickhanlonii deleted the rh/sync-flag-updates branch June 1, 2023 13:24

styfle mentioned this pull request Jun 30, 2023

chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 vercel/next.js#52005

Merged

styfle mentioned this pull request Jul 5, 2023

chore(deps): bump react to 7118f5dd7 vercel/next.js#52282

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up enableSyncDefaultUpdates flag a bit #26858

Clean up enableSyncDefaultUpdates flag a bit #26858

rickhanlonii commented May 26, 2023

rickhanlonii May 26, 2023

rickhanlonii May 26, 2023

react-sizebot commented May 26, 2023 •

edited

Loading

Clean up enableSyncDefaultUpdates flag a bit #26858

Clean up enableSyncDefaultUpdates flag a bit #26858

Conversation

rickhanlonii commented May 26, 2023

Overview

rickhanlonii May 26, 2023

Choose a reason for hiding this comment

rickhanlonii May 26, 2023

Choose a reason for hiding this comment

react-sizebot commented May 26, 2023 • edited Loading

Critical size changes

Significant size changes

react-sizebot commented May 26, 2023 •

edited

Loading