Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check_error_codes CI job #24692

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jun 8, 2022

The diff command was missing a --quiet argument, causing the job not to fail when unminified messages were found.

This commit will cause CI to fail because there's an unminified error in main. The unminified error will be fixed by #24688.

@acdlite acdlite requested a review from gnoff June 8, 2022 16:26
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 8, 2022
@sizebot
Copy link

sizebot commented Jun 8, 2022

Comparing: 060505e...0c6d41f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.76 kB 131.76 kB = 42.30 kB 42.30 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 137.03 kB 137.03 kB = 43.89 kB 43.89 kB
facebook-www/ReactDOM-prod.classic.js = 441.08 kB 441.08 kB = 80.67 kB 80.67 kB
facebook-www/ReactDOM-prod.modern.js = 426.39 kB 426.39 kB = 78.47 kB 78.47 kB
facebook-www/ReactDOMForked-prod.classic.js = 441.79 kB 441.79 kB = 80.88 kB 80.89 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0c6d41f

The diff command was missing a --quiet argument, causing the job not to
fail when unminified messages were found.
@acdlite acdlite force-pushed the fix-check-error-codes branch from 2769140 to 0c6d41f Compare June 8, 2022 16:58
@acdlite acdlite merged commit 42b330c into facebook:main Jun 8, 2022
Copy link

@farisei77 farisei77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [ ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants