Skip to content

Commit

Permalink
Fix check_error_codes CI job
Browse files Browse the repository at this point in the history
The diff command was missing a --quiet argument, causing the job not to
fail when unminified messages were found.

This commit will cause CI to fail because there's an unminified error
in main. The unminified error will be fixed by #24688.
  • Loading branch information
acdlite committed Jun 8, 2022
1 parent 7e8a020 commit 2769140
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ jobs:
name: Search build artifacts for unminified errors
command: |
yarn extract-errors
git diff || (echo "Found unminified errors. Either update the error codes map or disable error minification for the affected build, if appropriate." && false)
git diff --quiet || (echo "Found unminified errors. Either update the error codes map or disable error minification for the affected build, if appropriate." && false)
yarn_test:
docker: *docker
Expand Down

0 comments on commit 2769140

Please sign in to comment.