Tweaked landing page styles #19665
Tweaked landing page styles #19665
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 47b5778:
|
bvaughn
force-pushed
the
profiler-landing-page
branch
from
6b03e08
to
0fc09e2
Compare
|
|
||
| .Column { | ||
| margin: 2rem; | ||
| margin-right: 0; |
There was a problem hiding this comment.
This seems to break narrow layouts
There was a problem hiding this comment.
Hm. Narrow layouts were much more broken before, FWIW. (Broke at a much less narrow width.)
There was a problem hiding this comment.
We can iterate on this later 😄 I'm on PTO atm because I'm moving, so I'm going to land this change as-is to unblock the loading spinner work. Will iterate more when I'm back in the office :)
There was a problem hiding this comment.
Narrow layouts were much more broken before, FWIW
Yeah, it definitely was 😆 Thanks for fixing this!
Co-authored-by: E-Liang Tan <[email protected]>
* Tweaked landing page styles * Update GitHub link Co-authored-by: E-Liang Tan <[email protected]>
Follow up for #19634
Better match style conventions within other DevTools packages, remove some unnecessary wrapper DOM elements, improve resize behavior, etc.
cc @kartikcho @taneliang
Before
After