Revert "Revert "Dispatch commands to both UIManagers from both renderers (#17211)" (#17232)" #17799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers (facebook#17211)" (facebook#17232)" This reverts commit d0fc0ba.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d779fd:
|
|
Looks good to me 👍 |
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Jan 8, 2020
…ers (facebook#17211)" (facebook#17232)" (facebook#17799) * Revert "Revert "Dispatch commands to both UIManagers from both renderers (facebook#17211)" (facebook#17232)" This reverts commit d0fc0ba. * Clean up another __DEV__ warning check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d0fc0ba.
This is a reland of #17211.
This is our second attempt at making calls to dispatchCommand in Fabric go through the FabricUIManager. This had to be reverted before because the native code didn't have these commands implemented yet for Fabric. They do now so this is safe to land.