Revert "Dispatch commands to both UIManagers from both renderers (#17… #17232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebook#17211)" This reverts commit 8eee0eb.
yungsters
approved these changes
Oct 31, 2019
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Oct 31, 2019
…ebook#17211)" (facebook#17232) This reverts commit 8eee0eb.
trueadm
pushed a commit
to trueadm/react
that referenced
this pull request
Nov 4, 2019
…ebook#17211)" (facebook#17232) This reverts commit 8eee0eb.
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Jan 7, 2020
…ers (facebook#17211)" (facebook#17232)" This reverts commit d0fc0ba.
elicwhite
added a commit
that referenced
this pull request
Jan 8, 2020
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Jan 8, 2020
…ers (facebook#17211)" (facebook#17232)" (facebook#17799) * Revert "Revert "Dispatch commands to both UIManagers from both renderers (facebook#17211)" (facebook#17232)" This reverts commit d0fc0ba. * Clean up another __DEV__ warning check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17211 needs to be reverted because the Fabric components on iOS aren't implementing commands yet through the Fabric pipeline. Those commands will need to be implemented and then we can revert this revert.