Remove instructions about IP address on iOS #8660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @hramos and @joelcloralt to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
👍 @facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
|
The documentation for Using the offline bundle still appears to be incorrect. It references uncommenting a line that does not exist. It would be great if it was updated with the correct way of doing this. |
|
@apearce Thank you for reporting, I'll look into this. |
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: The documentation was not updated after this change : Implemented automatic IP detection for iOS (8c29a52) Fixes facebook#8651. Closes facebook#8660 Differential Revision: D3539749 fbshipit-source-id: fe3b37c446a8c37941adbb08c4301284950a176a
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: The documentation was not updated after this change : Implemented automatic IP detection for iOS (8c29a52) Fixes facebook#8651. Closes facebook#8660 Differential Revision: D3539749 fbshipit-source-id: fe3b37c446a8c37941adbb08c4301284950a176a
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: The documentation was not updated after this change : Implemented automatic IP detection for iOS (8c29a52) Fixes #8651. Closes facebook/react-native#8660 Differential Revision: D3539749 fbshipit-source-id: fe3b37c446a8c37941adbb08c4301284950a176a
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation was not updated after this change : Implemented automatic IP detection for iOS (8c29a52)
Fixes #8651.