Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update docs for "Running on Device" #8651

Closed
jefflau opened this issue Jul 8, 2016 · 4 comments
Closed

[Docs] Update docs for "Running on Device" #8651

jefflau opened this issue Jul 8, 2016 · 4 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@jefflau
Copy link

jefflau commented Jul 8, 2016 •
edited
Loading

Hi there,

I'm new to React Native and I was having problems with Running on Device yesterday on iOS. I was following this section of the docs:

https://facebook.github.io/react-native/docs/running-on-device-ios.html

I realised after I was using 0.28 and in the latest stable release 0.29 you don't have to change localhost to your IP Address on the network as stated in these docs.. In fact I couldn't even find localhost in the AppDelegate.m so this part no longer seems relevant and may be confusing to people reading it.
@jefflau jefflau changed the title Update docs for "Running on Device" [Docs] Update docs for "Running on Device" Jul 8, 2016
@charpeni
Copy link
Contributor

charpeni commented Jul 8, 2016

@facebook-github-bot label Documentation

@ghost ghost added Documentation Ran Commands One of our bots successfully processed a command. labels Jul 8, 2016
@charpeni charpeni mentioned this issue Jul 8, 2016
Closed
@ghost ghost closed this as completed in 65ff819 Jul 9, 2016
@inetfuture
Copy link

I'm curious, how does it work now?

@charpeni
Copy link
Contributor

@inetfuture You can refer to 8c29a52

@inetfuture
Copy link

get it, thanks

grabbou pushed a commit that referenced this issue Jul 13, 2016
@charpeni @grabbou
Remove instructions about IP address on iOS
dc57f95 
Summary:
The documentation was not updated after this change : Implemented automatic IP detection for iOS (8c29a52)

Fixes #8651.
Closes #8660

Differential Revision: D3539749

fbshipit-source-id: fe3b37c446a8c37941adbb08c4301284950a176a
grabbou pushed a commit that referenced this issue Jul 21, 2016
@charpeni @grabbou
Remove instructions about IP address on iOS
5b34ccb 
Summary:
The documentation was not updated after this change : Implemented automatic IP detection for iOS (8c29a52)

Fixes #8651.
Closes #8660

Differential Revision: D3539749

fbshipit-source-id: fe3b37c446a8c37941adbb08c4301284950a176a
samerce pushed a commit to iodine/react-native that referenced this issue Aug 23, 2016
@charpeni @samerce
Remove instructions about IP address on iOS
bb085f1 
Summary:
The documentation was not updated after this change : Implemented automatic IP detection for iOS (8c29a52)

Fixes facebook#8651.
Closes facebook#8660

Differential Revision: D3539749

fbshipit-source-id: fe3b37c446a8c37941adbb08c4301284950a176a
mpretty-cyro pushed a commit to HomePass/react-native that referenced this issue Aug 25, 2016
@charpeni
Remove instructions about IP address on iOS
288dcf5 
Summary:
The documentation was not updated after this change : Implemented automatic IP detection for iOS (8c29a52)

Fixes facebook#8651.
Closes facebook#8660

Differential Revision: D3539749

fbshipit-source-id: fe3b37c446a8c37941adbb08c4301284950a176a
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jefflau @inetfuture @charpeni @react-native-bot