Set defaults in RCTBundleURLProvider so development mode is the default #8404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @nathanajah and @shaneosullivan to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
jsierles
force-pushed
the
fix-dev-mode-default-false
branch
from
84f3ce3 to
490d42a
Compare
|
@nathanajah is looking into changing this so we apply the defaults in the constructor. We should also get rid of the dispatch_once. |
|
@javache Sounds good - would be good to get this into 0.29 to avoid confusion on the issue: |
ghost
added
the
CLA Signed
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @nathanajah as a potential reviewer. Could you take a look please or cc someone with more context? |
ghost
added
the
CLA Signed
|
I think this has been fixed already, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up from #8400 and 9845f49.
Sets URL parameters for ensuring dev mode is enabled by default.
Test Plan
Install React Native in a fresh app from react-native init.
update AppDelegate.m to use the new default development URL generator:
jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index.ios" fallbackResource:nil];
Run on iOS device or simulator, and ensure that the dev menu can be pulled up.