Implemented automatic IP detection for iOS #8091

nathanajah · 2016-06-13T14:11:27Z

Implemented automatic IP detection for iOS, based on #6345 and #6362.
As the previous pull requests did, this works by writing the IP address of the host to a file.

Test plan:
npm pack on the commit and create a new project by doing react-native init using the generated package.
With both the computer and the device on the same wireless connection, run the generated project on the device.
Make sure that the device loads the bundle successfully from the packager.
Turn off the packager, and run the app again.
Make sure that the device loads the pre-packaged bundle successfully.

facebook-github-bot · 2016-06-13T14:12:25Z

By analyzing the blame information on this pull request, we identified @geof90 and @frantic to be potential reviewers.

javache · 2016-06-13T14:21:42Z

React/Base/RCTBundleURLProvider.m

+{
+  NSString *ipPath = [[NSBundle mainBundle] pathForResource:@"ip" ofType:@"txt"];
+  NSString *ip = [NSString stringWithContentsOfFile:ipPath encoding:NSUTF8StringEncoding error:nil];
+  ip = [ip stringByTrimmingCharactersInSet:[NSCharacterSet characterSetWithCharactersInString:@"\n"]];


Use [NSCharacterSet newlineCharacterSet]. I'd also assign it immediately to ipGuess instead of making that a separate assignment.

javache · 2016-06-13T14:23:24Z

Looks awesome!

javache · 2016-06-13T16:27:18Z

React/Base/RCTBundleURLProvider.m


 @implementation RCTBundleURLProvider

+ (void)initialize


Can you gate this with RCT_DEV? We don't want to run this in production.

javache · 2016-06-13T17:09:06Z

React/Base/RCTBundleURLProvider.m


 @implementation RCTBundleURLProvider

+ (void)initialize
+{
+#if RCT_DEV


You should put this outside the + (void)initialize, otherwise we'll still be executing an empty method in prod.

javache · 2016-06-13T22:11:11Z

@facebook-github-bot shipit

ghost · 2016-06-13T22:11:51Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

Summary: Implemented automatic IP detection for iOS, based on facebook#6345 and facebook#6362. As the previous pull requests did, this works by writing the IP address of the host to a file. Closes facebook#8091 Differential Revision: D3427657 Pulled By: javache fbshipit-source-id: 3f534c9b32c4d6fb9615fc2e2c3c3aef421454c5

jsierles · 2016-06-22T07:51:53Z

Nice work on this! Just wanted to comment on a couple things. It looks like the default settings are never explicitly enabled on boot, so dev mode is disabled by default now, unless you add this to AppDelegate:

[[RCTBundleURLProvider sharedSettings] setEnableDev:TRUE];

It looks like the intent was to set defaults at initialization, but setDefaults never gets called.

Also noticed a typo here: https://github.com/facebook/react-native/blob/master/React/Base/RCTBundleURLProvider.m#L165

Happy to submit a PR once I understand the original intention on setting defaults!

javache · 2016-06-22T09:17:32Z

Looks like we're missing a call to setDefaults yeah. @nathanajah: can you add this?

jondot · 2016-06-22T11:38:35Z

Turning your attention to this, already done via https://github.com/jondot/react-native-network-boot where I believe my approach unified edge cases such as multiple interfaces, virtualbox, etc. and doesn't touch React Native core.

jsierles · 2016-06-24T09:29:27Z

Added #8400 to resolve this. @jondot, your work looks good, maybe submit a PR with the improved IP detection? I think it's important for this to live in React Native core, as testing on an iOS device today is a frustrating experience for first-time users.

nathanajah · 2016-06-24T09:50:05Z

Hi @jsierles! Sorry for forgetting to reply here, but commit 9845f49 should have resolved it. Thanks!

jsierles · 2016-06-24T10:06:25Z

Thanks! However shouldn't the defaults be set without having to call that method? Since they are defaults.

jsierles · 2016-06-24T13:11:17Z

@nathanajah Added a new PR to only address the defaults not being set automatically: #8404

nihgwu · 2016-06-26T09:06:36Z

I think it should be addressed about the development mode issue in the release note of 0.29RC or release a new RC version with the patch shipped, since i've upgrade my app to 0.29 and suffered a lot from this issue
I changed AppDelegate.m to the new form and got various errors such as

ExceptionsManager.js:55Module HMRClient is not a registered callable module.

or

ExceptionsManager.js:55locals[0] does not appear to be a `module` object with Hot Module replacement API enabled. You should disable react-transform-hmr in production by using `env` section in Babel configuration. See the example in README: https://github.com/gaearon/react-transform-hmr

if I enabled the hot reload module feature

It's really annoying and frustrating as I can't run my app then, I tried everything I can do such as react-native upgrade or reinstall the node_modules or clear and rebuild the project and finally I noticed that in the terminal it was requesting the bundle with dev=false
I've solved the problem by launch the commit 9845f49 manually now

jondot · 2016-07-04T14:37:19Z

@jsierles just to verify, you think it's important to live in react core (i've been using this in my apps as an npm module)? and then, do you think i should submit a new PR for this, together with a modification for the default template that uses it?

Thanks!

Summary: Implemented automatic IP detection for iOS, based on facebook#6345 and facebook#6362. As the previous pull requests did, this works by writing the IP address of the host to a file. Closes facebook#8091 Differential Revision: D3427657 Pulled By: javache fbshipit-source-id: 3f534c9b32c4d6fb9615fc2e2c3c3aef421454c5

Summary: Implemented automatic IP detection for iOS, based on #6345 and #6362. As the previous pull requests did, this works by writing the IP address of the host to a file. Closes facebook/react-native#8091 Differential Revision: D3427657 Pulled By: javache fbshipit-source-id: 3f534c9b32c4d6fb9615fc2e2c3c3aef421454c5

Summary: By default, when a react-native app launches in development mode on a physical iOS device, it attempts to load the JS bundle from a packager at `http://_your-local-ip-address_.xip.io:8081/`. This change removes the use of `xip.io`, which changes that url to: `http://_your-local-ip-address_:8081/`  Background: The automatic IP detection feature (introduced [here](#8091)) is super handy. However, it’s use of `xip.io` has caused myself and others much grief. Some routers do not allow or have intermittent errors when trying to resolve DNS names to local IP addresses. This prompted the introduction of a [DISABLE_XIP feature](#13326), which helps. However, I don’t believe the use of `xip.io` is needed at all. Based on [this comment](8c29a52#commitcomment-18224788), it appears the original reason for using `xip.io` was to “circumvent the numeric IP address limitation in ATS”. But, the reason you can’t create ATS exceptions for raw IP addresses is that ATS is not enforced for raw IP addresses _at all_. You can read the Apple documentation [here](https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html), the relevant portion is: > App Transport Security (ATS) applies only to connections made to public host names. The system does not provide ATS protection to connections made to: > * Internet protocol (IP) addresses > * Unqualified host names > * Local hosts employing the .local top-level domain (TLD) For example, in iOS, if you attempt to make an http request (note: _not_ https) to `http://www.google.com` you will get an error due to ATS. However, you can make the same request to `http://172.217.6.14/` (which for me is the same server) and the request will succeed. And in fact, if an ATS exception _was_ needed, the DISABLE_XIP feature shouldn’t work at all, but it does. In short, using `xip.io` with ATS exceptions is unnecessary, causes some very annoying problems for some people, and I think it should just be removed. Run the app on a physical iOS device and verify that it can load the JS bundle from the host computer's IP. [Implemented automatic IP detection for iOS #8091](#8091) [Added option to disable xip #13326](#13326)  [INTERNAL] [BUGFIX] [./scripts] - Removed use of xip.io Closes #17642 Differential Revision: D6814609 Pulled By: hramos fbshipit-source-id: f2faebd6a29b0b211d78cdfe8e195906307ab552

Summary: Implemented automatic IP detection for iOS, based on #6345 and #6362. As the previous pull requests did, this works by writing the IP address of the host to a file. Closes facebook/react-native#8091 Differential Revision: D3427657 Pulled By: javache fbshipit-source-id: 3f534c9b32c4d6fb9615fc2e2c3c3aef421454c5

Implemented automatic IP detection on iOS

fd5c7c0

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 13, 2016

javache reviewed Jun 13, 2016
View reviewed changes

nathanajah added 2 commits June 13, 2016 15:46

Changed ipGuess assignment

0793bb3

Used newlineCharacterSet

9d4902f

javache reviewed Jun 13, 2016
View reviewed changes

Made requested changes

ff19d6d

javache reviewed Jun 13, 2016
View reviewed changes

javache added GH Review: accepted and removed GH Review: review-needed labels Jun 13, 2016

nathanajah and others added 2 commits June 13, 2016 19:41

Moved RCT_DEV check outside the method

a12038a

Merge branch 'master' into master

8e2a82c

ghost added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jun 13, 2016

ghost closed this in 8c29a52 Jun 13, 2016

jsierles mentioned this pull request Jun 24, 2016

Set defaults in RCTBundleURLProvider so development mode is the default #8400

Closed

nihgwu mentioned this pull request Jun 30, 2016

locals[0] does not appear to be a module object with Hot Module Replacement API enabled. #8463

Closed

jvranish mentioned this pull request Jan 17, 2018

Removed use of xip.io, as it's not needed. #17642

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented automatic IP detection for iOS #8091

Implemented automatic IP detection for iOS #8091

nathanajah commented Jun 13, 2016

facebook-github-bot commented Jun 13, 2016

javache Jun 13, 2016

javache commented Jun 13, 2016

javache Jun 13, 2016

javache Jun 13, 2016

javache commented Jun 13, 2016

ghost commented Jun 13, 2016

jsierles commented Jun 22, 2016

javache commented Jun 22, 2016

jondot commented Jun 22, 2016 •

edited

Loading

jsierles commented Jun 24, 2016

nathanajah commented Jun 24, 2016

jsierles commented Jun 24, 2016

jsierles commented Jun 24, 2016

nihgwu commented Jun 26, 2016

jondot commented Jul 4, 2016

Implemented automatic IP detection for iOS #8091

Implemented automatic IP detection for iOS #8091

Conversation

nathanajah commented Jun 13, 2016

facebook-github-bot commented Jun 13, 2016

javache Jun 13, 2016

Choose a reason for hiding this comment

javache commented Jun 13, 2016

javache Jun 13, 2016

Choose a reason for hiding this comment

javache Jun 13, 2016

Choose a reason for hiding this comment

javache commented Jun 13, 2016

ghost commented Jun 13, 2016

jsierles commented Jun 22, 2016

javache commented Jun 22, 2016

jondot commented Jun 22, 2016 • edited Loading

jsierles commented Jun 24, 2016

nathanajah commented Jun 24, 2016

jsierles commented Jun 24, 2016

jsierles commented Jun 24, 2016

nihgwu commented Jun 26, 2016

jondot commented Jul 4, 2016

jondot commented Jun 22, 2016 •

edited

Loading