[Touchable] Expose the touch-retention offset as a prop #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ide
force-pushed
the
touch-retention-offset
branch
4 times, most recently
from
9fcf9b2 to
eec81b2
Compare
ide
force-pushed
the
touch-retention-offset
branch
2 times, most recently
from
1fc167f to
a11587c
Compare
ide
force-pushed
the
touch-retention-offset
branch
2 times, most recently
from
12b1d5a to
d5d18eb
Compare
|
I've been using this for nav bar buttons and it's pretty helpful to approximate UIKit's behavior. Any takers? |
ide
force-pushed
the
touch-retention-offset
branch
2 times, most recently
from
1af9a81 to
d0e794a
Compare
|
cc @vjeux and @ericvicenti since this is most useful for nav bar buttons |
ide
force-pushed
the
touch-retention-offset
branch
from
d0e794a to
a322ec2
Compare
ide
force-pushed
the
touch-retention-offset
branch
from
a322ec2 to
c494ec9
Compare
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/330079883868498/int_phab to review. |
ide
force-pushed
the
touch-retention-offset
branch
from
c494ec9 to
78a5332
Compare
ide
force-pushed
the
touch-retention-offset
branch
from
78a5332 to
72c2517
Compare
ide
force-pushed
the
touch-retention-offset
branch
3 times, most recently
from
ac4470a to
1509a10
Compare
|
Rebased and renamed this to press retention offset, which distinguishes between touches and button presses. I've been using this for awhile since it's useful in real apps. |
ide
force-pushed
the
touch-retention-offset
branch
from
1509a10 to
9142b81
Compare
ide
force-pushed
the
touch-retention-offset
branch
from
9142b81 to
dcdf174
Compare
ide
force-pushed
the
touch-retention-offset
branch
from
dcdf174 to
f9138d3
Compare
|
@ide updated the pull request. |
The press-retention offset defines a rect around a touchable component in which the press is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought pressRetentionOffset was a more informative name than pressRectOffset).
ide
force-pushed
the
touch-retention-offset
branch
from
f9138d3 to
9dab4c8
Compare
|
@vjeux could you take a look at this next week? We use this in ExNavigator buttons and it's been working fine for months. Flow is happy with it too. So it's mostly a matter of naming and the API. |
|
Sounds good to me. @facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/330079883868498/int_phab to review. |
sunnylqm
pushed a commit
to sunnylqm/react-native
that referenced
this pull request
Dec 2, 2015
Summary: The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset) Fixes facebook#198 Closes facebook#713 Reviewed By: svcscm Differential Revision: D2115370 Pulled By: shayne fb-gh-sync-id: c3f57940dfa3806f9c88df03a01d4d65bb58cf32
Crash--
pushed a commit
to Crash--/react-native
that referenced
this pull request
Dec 24, 2015
Summary: The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset) Fixes facebook#198 Closes facebook#713 Reviewed By: svcscm Differential Revision: D2115370 Pulled By: shayne fb-gh-sync-id: c3f57940dfa3806f9c88df03a01d4d65bb58cf32
evollu
pushed a commit
to evollu/react-native
that referenced
this pull request
Dec 15, 2016
expose this property to make Text having same property as Touchable as facebook#713 solve Text in Text rect offset issue in facebook#11462
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
* Added instrutions to add platform-tools to Path. This allows windows to find adb.exe, a file required for react-native run-android to work properly. * removed wrong block class
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Feb 10, 2021
* Add nullability checks (facebook#704) * Update RCTCxxBridge.mm * add nullability checks * 63 tooltips * Add Tooltip support (facebook#701) Co-authored-by: chiuam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)
Fixes #198