Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Touchable] Customizing "press rect offset" of touchable components #198

Closed
ide opened this issue Mar 25, 2015 · 3 comments
Closed

[Touchable] Customizing "press rect offset" of touchable components #198

ide opened this issue Mar 25, 2015 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Mar 25, 2015

The press-rect offset defines a box around a touchable component in which a touch still counts. I'd like to be able to customize this box (specifically set the press-rect offset to (0,0,0,0)) by exposing it as a prop. Looking for suggestions for what to name the prop, or maybe there is already a term for this in the HCI literature.
ide added a commit to ide/react-native that referenced this issue Apr 7, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
b78a73a 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 7, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
cde964d 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 7, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
82b8837 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 7, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
23c04d7 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
@ide ide mentioned this issue Apr 7, 2015
Closed
ide added a commit to ide/react-native that referenced this issue Apr 8, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
59e07bd 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 10, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
a6b2af9 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 10, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
f002f26 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 10, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
2554db7 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 12, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
5af1545 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 13, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
80c7bb5 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 13, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
cd90cdf 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 14, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
9fcf9b2 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 14, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
896cad2 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 14, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
3aedab4 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 15, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
eec81b2 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 15, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
0a4a693 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 15, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
edffe6d 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 16, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
f028c35 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 16, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
8d3eeb0 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 16, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
db88472 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 21, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
f87ae72 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 22, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
1fc167f 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 28, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
9d7b20c 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 28, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
a11587c 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 29, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
5296133 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 30, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
1b080e3 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue Apr 30, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
12b1d5a 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 1, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
406ae37 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 1, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
d5d18eb 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 1, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
b48c367 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 5, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
1e1550f 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 8, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
1af9a81 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 8, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
12a97d7 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 8, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
df36a87 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 8, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
d0e794a 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 13, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
a322ec2 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 13, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
25f6aed 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 15, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
aba4de4 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 16, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
9279c5f 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 16, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
5a1135c 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 16, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
c34ec87 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 18, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
f1d2d08 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 18, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
780872d 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 19, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
89e5ee4 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 22, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
5e5caf9 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
ide added a commit to ide/react-native that referenced this issue May 29, 2015
@ide
[Touchable] Expose the touch-retention offset as a prop
35a4408 
The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
@brentvatne brentvatne changed the title Customizing "press rect offset" of touchable components [Touchable] Customizing "press rect offset" of touchable components May 31, 2015
@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

harrykiselev pushed a commit to harrykiselev/react-native that referenced this issue Aug 5, 2015
@zpao
Merge pull request facebook#198 from kemitchell/spdx-license
307e05d 
Use a Standard-Compliant License Identifier
@coderdave
Copy link

I like the idea of defining an area around a touchable component where the touch still counts. What's the way to handle this now? Just increase the size and padding which could potentially break the design?

@ide
Copy link
Contributor Author

ide commented Aug 28, 2015

That's a bit different since that increases the area that you can tap to start a touch. This issue is about customizing an enclosing box in which a touch is retained but not necessarily started.

@ide ide closed this as completed in f331d2a Nov 16, 2015
sunnylqm pushed a commit to sunnylqm/react-native that referenced this issue Dec 2, 2015
@ide @sunnylqm
Expose the touch-retention offset as a prop
03f4cb2 
Summary: The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
Closes facebook#713

Reviewed By: svcscm

Differential Revision: D2115370

Pulled By: shayne

fb-gh-sync-id: c3f57940dfa3806f9c88df03a01d4d65bb58cf32
Crash-- pushed a commit to Crash--/react-native that referenced this issue Dec 24, 2015
@ide @Crash--
Expose the touch-retention offset as a prop
81012f2 
Summary: The touch-retention offset defines a rect around a touchable component in which the touch is retained. Easiest way to see this is to touch a button in a real navigation bar and slide your finger out of the range and back in. This diff exposes the offset as a prop (I thought touchRetentionOffset was a more informative name than pressRectOffset)

Fixes facebook#198
Closes facebook#713

Reviewed By: svcscm

Differential Revision: D2115370

Pulled By: shayne

fb-gh-sync-id: c3f57940dfa3806f9c88df03a01d4d65bb58cf32
@facebook facebook locked as resolved and limited conversation to collaborators Jul 23, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Touchable] Expose the touch-retention offset as a prop ide/react-native
3 participants
@ide @coderdave @react-native-bot