Fixed images required from node_modules

[bestander]

This fixes #6638 by resolving AssetRegistry relatively.

[bestander]

cc @davidaurelio

[bestander]

David, when Haste update is propagated I'll be happy to add a test for this case.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @davidaurelio, @amasad and @martinbigio to be potential reviewers.

[ide]

Travis tests are failing:

:0: failed: caught "NSInternalInconsistencyException", "*** Assertion failure in -[RCTTestRunner runTest:module:initialProps:configurationBlock:expectErrorBlock:], /Users/travis/build/facebook/react-native/Libraries/RCTTest/RCTTestRunner.m:154: RedBox error: Unhandled JS Exception: Requiring unknown module "../../../../Libraries/Image/AssetRegistry.js". If you are sure the module is there, try restarting the packager or running "npm install"."

[bestander]

Thanks, James.
Maybe it needs haste change to propagate first

On Wednesday, 6 April 2016, James Ide [email protected] wrote:

Travis tests are failing:

:0: failed: caught "NSInternalInconsistencyException", "*** Assertion
failure in -[RCTTestRunner
runTest:module:initialProps:configurationBlock:expectErrorBlock:],
/Users/travis/build/facebook/react-native/Libraries/RCTTest/RCTTestRunner.m:154:
RedBox error: Unhandled JS Exception: Requiring unknown module
"../../../../Libraries/Image/AssetRegistry.js". If you are sure the module
is there, try restarting the packager or running "npm install"."

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#6822 (comment)

[davidaurelio]

node-haste v2.9.5 is published. Please update package.json to "node-haste": "~2.9.5", and bump the version in packager/package.json

[bestander]

will do, thanks

On Wed, Apr 6, 2016 at 11:15 AM, David Aurelio [email protected]
wrote:

node-haste v2.9.5 is published. Please update package.json to "node-haste":
"~2.9.5", and bump the version in packager/package.json

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#6822 (comment)

[davidaurelio]

oh, this needs even more changes. Lovely. Let me come to your desk

[facebook-github-bot]

@bestander updated the pull request.

[davidaurelio]

That looks like a sound solution! I couldn’t have come up with anything better than this!

[davidaurelio]

@facebook-github-bot import

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to Phabricator to review.