HMR fails to load "node_modules/react-transform/hmr/lib/index.js" on 0.24.0-rc

[ide]

When enabling HMR on 0.24.0-rc in a brand new template project, we get a redbox that says:

Requiring unknown module "node_modules/react-transform/hmr/lib/index.js". If you are sure the module is there, try restarting the packager or running "npm install".

I verified that node_modules/react-transform/hmr/lib/index.js exists, and running npm start -- --reset-cache doesn't resolve the issue either.

Repro steps: run ./scripts/test-manual-e2e.sh which sets up a new project and launches it in Android (need to have a simulator or device connected in advance). Enable HMR from the dev menu to get the redbox.

[martinbigio]

@ide /scripts/test-manual-e2e.sh are not run on CI, right?

[ide]

@martinbigio I believe that's correct. I ran the script with 0.24.0-rc on my MBP (OS X 10.11.4) with Node 5.9.1.

[mkonicek]

No tests for HMR on CircleCI yet but @bestander is working on it 🎉

[martinbigio]

ok, I'l try to take a look tomorrow, not sure what broke this. Does this also affect hmr while developing or only this e2e tests?

[ide]

I believe this happens when developing too. The manual E2E tests set up a new project with react-native init and launch the new Android/iOS app. Then I manually opened the dev menu and turned on HMR and got the error.

[martinbigio]

The problem was that we were using an old version of the preset due to this commit bc54a45.

The preset @1.5.2 doesn't include this fix: 3a1634e

cc @janicduplessis @bestander

[bestander]

Ok, #6814 should propagate in an hour.
We may want to cherry-pick it into 0.24.0, @ide

[martinbigio]

It's already on the list #6800 :)

[ide]

Thanks for the heads-up. I've cherry-picked it into 0.24-stable (tested -- HMR works) and will do another RC release after the fix for the AssetRegistry lands (#6822).