Fix proguard template for ReactProp and ReactPropGroup #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactProp and ReactPropGroup were moved in the annotations package but the proguard file was not updated accordingly. This caused apps to crash when built in release using proguard.
facebook-github-bot
added
GH Review: review-needed
CLA Signed
20 tasks
|
I have noticed this issue as well. |
|
Thanks for this! @facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/168362060204084/int_phab to review. |
ghost
closed this
in
bestander
pushed a commit
that referenced
this pull request
Feb 5, 2016
Summary: ReactProp and ReactPropGroup were moved in the annotations package but the proguard file was not updated accordingly. This caused apps to crash when built in release using proguard. Fixes #5655 Closes #5717 Reviewed By: svcscm Differential Revision: D2905573 Pulled By: lexs fb-gh-sync-id: 29ab14bacda7254d9896ff3991bf17d7fdfd6ea9
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary: ReactProp and ReactPropGroup were moved in the annotations package but the proguard file was not updated accordingly. This caused apps to crash when built in release using proguard. Fixes facebook#5655 Closes facebook#5717 Reviewed By: svcscm Differential Revision: D2905573 Pulled By: lexs fb-gh-sync-id: 29ab14bacda7254d9896ff3991bf17d7fdfd6ea9
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: ReactProp and ReactPropGroup were moved in the annotations package but the proguard file was not updated accordingly. This caused apps to crash when built in release using proguard. Fixes #5655 Closes facebook/react-native#5717 Reviewed By: svcscm Differential Revision: D2905573 Pulled By: lexs fb-gh-sync-id: 29ab14bacda7254d9896ff3991bf17d7fdfd6ea9
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactProp and ReactPropGroup were moved in the annotations package but the proguard file was not updated accordingly. This caused apps to crash when built in release using proguard.
Fixes #5655