[Android]Release crash "s.propTypes.style" #5655
Labels
Resolution: Locked
This issue was locked by the bot.
Comments
|
Hey Richard-Cao, thanks for reporting this issue! React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.
|
|
please help…… |
|
I remove whatever, I think this is react-native 0.19.0's bug, when release apk |
|
I go back to 0.18.0, not crash. |
|
+1 RN: 0.19.0 App crashes on release build, debug release works fine.
It works on RN 0.18.1 |
|
I manage to fix it by setting proguard to false in release build. @Richard-Cao to fix it make this change in you app build.gradle
|
|
I can confirm I have the same issue too. Like @AntiHate said disabling proguard is a workaround. |
|
@janicduplessis It is not a workaround since you would never publish an app without running it through some obfuscation |
|
@kristjanmik As a temporary workaround is what I meant. |
|
I think if publish app, should |
|
👍 +1 Had to use the proguard workaround. |
|
+1 |
|
I found the problem, ReactProp and ReactPropGroup were moved to the annotations package and the proguard file was not updated accordingly. To fix it you can change for in your proguard-rules.pro line 45-46 I'll submit a PR to fix the templates. |
|
Awesome @janicduplessis, it solved the props problem. Are you running into this problem as well with a fresh project + minification + proguard with -dontobfuscate commented out. Here is a dump: |
|
@kristjanmik I never tried without -dontobfuscate. My guess it's that it is not supported at the moment, maybe @mkonicek or @bestander could help you with that. |
|
Awesome!! @janicduplessis |
This was referenced Feb 4, 2016
20 tasks
ghost
closed this as
bestander
pushed a commit
that referenced
this issue
Feb 5, 2016
Summary: ReactProp and ReactPropGroup were moved in the annotations package but the proguard file was not updated accordingly. This caused apps to crash when built in release using proguard. Fixes #5655 Closes #5717 Reviewed By: svcscm Differential Revision: D2905573 Pulled By: lexs fb-gh-sync-id: 29ab14bacda7254d9896ff3991bf17d7fdfd6ea9
|
Thanks @janicduplessis, this was driving me crazy... what I don't understand is why my |
pglotov
pushed a commit
to pglotov/react-native
that referenced
this issue
Mar 15, 2016
Summary: ReactProp and ReactPropGroup were moved in the annotations package but the proguard file was not updated accordingly. This caused apps to crash when built in release using proguard. Fixes facebook#5655 Closes facebook#5717 Reviewed By: svcscm Differential Revision: D2905573 Pulled By: lexs fb-gh-sync-id: 29ab14bacda7254d9896ff3991bf17d7fdfd6ea9
|
@kristjanmik I am running into exactly your same error. Did you ever find a solution? @mkonicek Is it true what @janicduplessis suggested that |
|
@kristjanmik I was able to get past that error by adding the following proguard rule: You can refer to this StackOverflow question for more info. |
|
it is very strange,my App crashes on release build in RN 0.49, debug release works fine. -keep class * extends com.facebook.react.bridge.JavaScriptModule { *; } |
|
I had the same problem, it ended up being an outdated module I was including. https://github.com/d-a-n/react-native-modal-picker I switched to an updated fork, and it worked https://github.com/peacechen/react-native-modal-selector |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I found
s.propTypes.styleinindex.android.bundlehere:but debug is right, release crash.
why?
react-native version: 0.19.0
used: react-native-scrollable-tab-view
The text was updated successfully, but these errors were encountered: