[iOS] automaticallyAdjustKeyboardInsets not shifting scrollview content #46732
Conversation
facebook-github-bot
added
CLA Signed
packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputView.mm
Outdated
Show resolved
Hide resolved
...ges/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
Outdated
Show resolved
Hide resolved
|
Hi @javache, just a friendly reminder— the issue reporter is asking for any updates regarding this matter. Could you please assist in resuming the review? Thank you! |
...es/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.h
Outdated
Show resolved
Hide resolved
...s/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
Outdated
Show resolved
Hide resolved
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…/fix_scrollview_inset
| if (inputAccessoryView) { | ||
| // Text input view is within the inputAccessoryView. | ||
| contentDiff = keyboardEndFrame.origin.y - keyboardBeginFrame.origin.y; | ||
| } |
There was a problem hiding this comment.
Do we still want an early return here? Or should we have a general check for contentDiff == 0?
There was a problem hiding this comment.
I prefer to maintain the same logic as the old architecture, which does not perform early return checks or check for contentDiff == 0.
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @zhongwuzw in 2d9933e When will my fix make it into a release? | How to file a pick request? |
…6732) Summary: Fixes #46595 . It seems #37766 broke the `automaticallyAdjustKeyboardInsets` when input accessory view become first responder. [IOS] [FIXED] - automaticallyAdjustKeyboardInsets not shifting scrollview content Pull Request resolved: #46732 Test Plan: Repro please see in ##46595 . Reviewed By: cipolleschi Differential Revision: D65072478 Pulled By: javache fbshipit-source-id: 7d5d7566438d4bb0e1d50074a953b18866e324d3
Summary:
Fixes #46595 . It seems #37766 broke the
automaticallyAdjustKeyboardInsetswhen input accessory view become first responder.Changelog:
[IOS] [FIXED] - automaticallyAdjustKeyboardInsets not shifting scrollview content
Test Plan:
Repro please see in ##46595 .