Include boost headers needed by rrc_text and rrc_textinput
#43608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Looks like android doesn't build on |
cortinico
reviewed
Mar 22, 2024
...-gradle-plugin/src/main/kotlin/com/facebook/react/tasks/internal/PreparePrefabHeadersTask.kt
Show resolved
Hide resolved
…ok/react/tasks/internal/PreparePrefabHeadersTask.kt
cortinico
approved these changes
Mar 22, 2024
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
If you want this in RC5 (which I suppose - cc @tomekzaw also), please file a pick request on https://github.com/reactwg/react-native-releases/issues/new/choose |
|
@cortinico merged this pull request in ad9f0b0. |
huntie
pushed a commit
that referenced
this pull request
Mar 25, 2024
Summary: Updates `PreparePrefabHeadersTask` to copy more headers from `boost`, specifically those required by `rrc_text` and `rrc_textinput`. ## Changelog: [ANDROID] [CHANGED] - Copy boost headers needed by `rrc_text` and `rrc_textinput` Pull Request resolved: #43608 Reviewed By: rshest Differential Revision: D55241345 Pulled By: cortinico fbshipit-source-id: e92164676ba78ee15b3678a55c9098b0c6214b69
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates
PreparePrefabHeadersTaskto copy more headers fromboost, specifically those required byrrc_textandrrc_textinput.Changelog:
[ANDROID] [CHANGED] - Copy boost headers needed by
rrc_textandrrc_textinputTest Plan: